fix(core): do not overwrite package.json start script
#15091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
@ondrej-stanek-ozobot the ci did not run. could you rebase and push up again? |
4cf21b4 to
07a9d8a
Compare
|
@xiongemi , I rebased on latest mainline, but I am unsure if it resolved the problem. Can you please check? |
xiongemi
approved these changes
Feb 22, 2023
|
the pr looks good, but the ci did not get triggered, so checks are not done. the ci needs to be run before the merge. maybe just try to rebase again? |
07a9d8a to
37b6879
Compare
|
@xiongemi , I rebased again, not sure if it helped. Could you please help to get the CI run completed? |
37b6879 to
ed9ce28
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not overwrite app's package.json
startscript if the app already defines it.Current Behavior
nx build <app>doesn't fully respect the contents ofapps/<app>/package.json. In particular, if the<app>'s package.json specifies custom script such as:{ "scripts": { "start": "next start -p ${PORT:=8080}" } }The custom configuration is lost during
nx build <app>and the generateddist/apps/<lib>/package.jsonmisses the custom port configuration:{ "scripts": { "start": "next start" },Expected Behavior
The file
dist/apps/<app>/package.jsonshould keep the custom start command, in this example it should be:{ "scripts": { "start": "next start -p ${PORT:=8080}" },The fix is simple and it is aligned with the existing logic for checking presence of
scriptssection.