Skip to content

fix(angular): set projectName as the default source for relevant generators #15664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Mar 14, 2023

Current Behavior

Some Angular generators with project as a required option fail the schema validation when it is not explicitly provided. The project option is not being auto-populated with the default project.

Expected Behavior

The relevant Angular generators should auto-populate the project option and pass the schema validation. The $default.$source should be set to projectName.

Related Issue(s)

Fixes #15658

@leosvelperez leosvelperez self-assigned this Mar 14, 2023
@vercel
Copy link

vercel bot commented Mar 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 3:58PM (UTC)

@leosvelperez leosvelperez force-pushed the angular/generators-project-name-source branch from 5577d02 to eea8693 Compare March 14, 2023 15:54
@leosvelperez leosvelperez marked this pull request as ready for review March 14, 2023 16:33
@leosvelperez leosvelperez requested a review from Coly010 as a code owner March 14, 2023 16:33
@leosvelperez leosvelperez merged commit ca8d24b into nrwl:master Mar 14, 2023
@leosvelperez leosvelperez deleted the angular/generators-project-name-source branch March 14, 2023 16:38
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular generate component stopped working after upgrading NX to v15.8.6
2 participants