feat(linter): add override for noImportsOfLazyLoadedLibraries #15670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
I can't help feeling like this is too strong... Maybe we should instead allow an array of exceptions to be passed? So that certain patterns like the Not easy to name the option but maybe something like: {
"allowedExceptionsToLazyLoadingCheck": [
"@foo/bar/testing",
"@baz/qux/testing"
]
}The downside of losing the protection is end user-facing, so that's why I feel like we need to try and ensure folks are not giving up on this lightly... |
b0e2524 to
651b367
Compare
JamesHenry
approved these changes
Mar 20, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Resolves #15514