Skip to content

fix(core): use pnpm exec instead of pnpx #7695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

jmcdo29
Copy link
Contributor

@jmcdo29 jmcdo29 commented Nov 10, 2021

pnpm is deprecating pnpx and suggests using pnpm exec instead.
pnpx still works at the moment, but if for whatever reason it
isn't installed then this pr can make create-nx-worksapce stsill work.

pnpx documenation

Current Behavior

create-nx-workspace uses pnpx for executing commands.

Expected Behavior

pnpx is deprecated and should be replaced by pnpm exec as described by their 6.13.0 release notes

pnpm is deprecating pnpx and suggests using pnpm exec instead.
pnpx still works at the moment, but if for whatever reason it
isn't installed then this pr can make create-nx-worksapce stsill work.

[pnpx documenation](https://pnpm.io/pnpx-cli)
@vercel
Copy link

vercel bot commented Nov 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/Ea4AGRREyiohKra119jiihuPwtyv
✅ Preview: Canceled

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit 474dc28 into nrwl:master Nov 12, 2021
@jmcdo29 jmcdo29 deleted the fix/pnpm-exec branch November 12, 2021 16:50
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants