Skip to content

fix(dep-graph): set workspaceLayout on initGraph #7774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2021
Merged

fix(dep-graph): set workspaceLayout on initGraph #7774

merged 1 commit into from
Nov 17, 2021

Conversation

philipjfulcher
Copy link
Collaborator

Current Behavior

  • workspaceLayout is not set for the given workspace, resulting in projects not being grouped correctly in the dep graph visualization.

Expected Behavior

  • workspaceLayout is set for the given workspace, resulting in projects being grouped correctly in the dep graph visualization.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Nov 17, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/J16tMecCcMLaNyo8L2X1C7XzKfrf
✅ Preview: Canceled

@philipjfulcher philipjfulcher enabled auto-merge (squash) November 17, 2021 18:07
@philipjfulcher philipjfulcher merged commit d7af894 into nrwl:master Nov 17, 2021
@nx-cloud
Copy link
Contributor

nx-cloud bot commented Nov 17, 2021

Nx Cloud Report

CI ran the following commands for commit 3bc53a2. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx affected --target=build --base=2566a818028b2bc0977d51388be308be026f4ef0 --head=3bc53a2358fcbf07bc269273021ebf71c485ee30 --parallel --max-parallel=3
#000000 nx affected --target=e2e --base=2566a818028b2bc0977d51388be308be026f4ef0 --head=3bc53a2358fcbf07bc269273021ebf71c485ee30 --exclude=e2e-next,e2e-gatsby,e2e-workspace-create,e2e-workspace-integrations,e2e-workspace-core,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-cli,e2e-nx-plugin,e2e-storybook,e2e-cypress,e2e-node,e2e-linter,e2e-je...
#000000 nx affected --target=e2e --base=2566a818028b2bc0977d51388be308be026f4ef0 --head=3bc53a2358fcbf07bc269273021ebf71c485ee30 --exclude=e2e-react-native,e2e-detox
#000000 nx affected --target=lint --base=2566a818028b2bc0977d51388be308be026f4ef0 --head=3bc53a2358fcbf07bc269273021ebf71c485ee30 --parallel --max-parallel=4
#000000 nx affected --target=test --base=2566a818028b2bc0977d51388be308be026f4ef0 --head=3bc53a2358fcbf07bc269273021ebf71c485ee30 --parallel --max-parallel=2
#000000 nx build typedoc-theme

Sent with 💌 from NxCloud.

FrozenPandaz pushed a commit that referenced this pull request Nov 17, 2021
@philipjfulcher @FrozenPandaz
fix(dep-graph): set workspaceLayout on initGraph (#7774)
07e37a5
@philipjfulcher philipjfulcher deleted the dep-graph-set-workspace-layout branch November 27, 2022 22:41
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@philipjfulcher