Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: serde-rs/json
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.117
Choose a base ref
...
head repository: serde-rs/json
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.118
Choose a head ref
  • 14 commits
  • 9 files changed
  • 2 contributors

Commits on Apr 25, 2024

  1. impl Hash for Value

    edwardycl committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    16eb872 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. Configuration menu
    Copy the full SHA
    8e475f1 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1136 from dtolnay/docsrs

    Rely on docs.rs to define --cfg=docsrs by default
    dtolnay authored May 19, 2024
    Configuration menu
    Copy the full SHA
    62839b7 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2024

  1. Resolve needless_raw_string_hashes pedantic clippy lint in test

        warning: unnecessary hashes around raw string literal
            --> tests/test.rs:2313:16
             |
        2313 |     assert_eq!(r#"42"#, array_from_str[1].get());
             |                ^^^^^^^
             |
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
             = note: `-W clippy::needless-raw-string-hashes` implied by `-W clippy::pedantic`
             = help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_raw_string_hashes)]`
        help: remove all the hashes around the string literal
             |
        2313 -     assert_eq!(r#"42"#, array_from_str[1].get());
        2313 +     assert_eq!(r"42", array_from_str[1].get());
             |
    
        warning: unnecessary hashes around raw string literal
            --> tests/test.rs:2315:16
             |
        2315 |     assert_eq!(r#"null"#, array_from_str[3].get());
             |                ^^^^^^^^^
             |
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
        help: remove all the hashes around the string literal
             |
        2315 -     assert_eq!(r#"null"#, array_from_str[3].get());
        2315 +     assert_eq!(r"null", array_from_str[3].get());
             |
    
        warning: unnecessary hashes around raw string literal
            --> tests/test.rs:2392:16
             |
        2392 |     assert_eq!(r#"42"#, array_from_str[1].get());
             |                ^^^^^^^
             |
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
        help: remove all the hashes around the string literal
             |
        2392 -     assert_eq!(r#"42"#, array_from_str[1].get());
        2392 +     assert_eq!(r"42", array_from_str[1].get());
             |
    
        warning: unnecessary hashes around raw string literal
            --> tests/test.rs:2394:16
             |
        2394 |     assert_eq!(r#"null"#, array_from_str[3].get());
             |                ^^^^^^^^^
             |
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
        help: remove all the hashes around the string literal
             |
        2394 -     assert_eq!(r#"null"#, array_from_str[3].get());
        2394 +     assert_eq!(r"null", array_from_str[3].get());
             |
    
        warning: unnecessary hashes around raw string literal
            --> tests/test.rs:2399:16
             |
        2399 |     assert_eq!(r#"42"#, array_from_reader[1].get());
             |                ^^^^^^^
             |
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
        help: remove all the hashes around the string literal
             |
        2399 -     assert_eq!(r#"42"#, array_from_reader[1].get());
        2399 +     assert_eq!(r"42", array_from_reader[1].get());
             |
    
        warning: unnecessary hashes around raw string literal
            --> tests/test.rs:2401:16
             |
        2401 |     assert_eq!(r#"null"#, array_from_reader[3].get());
             |                ^^^^^^^^^
             |
             = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
        help: remove all the hashes around the string literal
             |
        2401 -     assert_eq!(r#"null"#, array_from_reader[3].get());
        2401 +     assert_eq!(r"null", array_from_reader[3].get());
             |
    dtolnay committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    18e9b89 View commit details
    Browse the repository at this point in the history
  2. Ignore large_digit_groups pedantic clippy lint in test

        warning: digit groups should be smaller
           --> tests/test.rs:962:9
            |
        962 |         51.24817837550540_4,  // 51.2481783755054_1
            |         ^^^^^^^^^^^^^^^^^^^ help: consider: `51.248_178_375_505_404`
            |
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
            = note: `-W clippy::large-digit-groups` implied by `-W clippy::pedantic`
            = help: to override `-W clippy::pedantic` add `#[allow(clippy::large_digit_groups)]`
    
        warning: digit groups should be smaller
           --> tests/test.rs:963:10
            |
        963 |         -93.3113703768803_3,  // -93.3113703768803_2
            |          ^^^^^^^^^^^^^^^^^^ help: consider: `93.311_370_376_880_33`
            |
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
    
        warning: digit groups should be smaller
           --> tests/test.rs:964:10
            |
        964 |         -36.5739948427534_36, // -36.5739948427534_4
            |          ^^^^^^^^^^^^^^^^^^^ help: consider: `36.573_994_842_753_436`
            |
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
    
        warning: digit groups should be smaller
           --> tests/test.rs:965:9
            |
        965 |         52.31400820410624_4,  // 52.31400820410624_
            |         ^^^^^^^^^^^^^^^^^^^ help: consider: `52.314_008_204_106_244`
            |
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
    
        warning: digit groups should be smaller
           --> tests/test.rs:966:9
            |
        966 |         97.4536532003468_5,   // 97.4536532003468_4
            |         ^^^^^^^^^^^^^^^^^^ help: consider: `97.453_653_200_346_85`
            |
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
    dtolnay committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    b83d243 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c9b9f88 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fa8aa22 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2024

  1. Delete unused associated constant from lexical

        warning: associated constant `NEGATIVE_INFINITY_BITS` is never used
           --> src/lexical/num.rs:223:11
            |
        175 | pub trait Float: Number {
            |           ----- associated constant in this trait
        ...
        223 |     const NEGATIVE_INFINITY_BITS: Self::Unsigned;
            |           ^^^^^^^^^^^^^^^^^^^^^^
            |
            = note: `#[warn(dead_code)]` on by default
    dtolnay committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    4c894ea View commit details
    Browse the repository at this point in the history
  2. Another lexical const that is unused, though not in test

        warning: associated constant `SIGN_MASK` is never used
           --> src/lexical/num.rs:210:11
            |
        175 | pub trait Float: Number {
            |           ----- associated constant in this trait
        ...
        210 |     const SIGN_MASK: Self::Unsigned;
            |           ^^^^^^^^^
            |
            = note: `#[warn(dead_code)]` on by default
    dtolnay committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    24d868f View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Merge pull request #1127 from edwardycl/hash

    impl `Hash` for `Value`
    dtolnay authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    eb0330a View commit details
    Browse the repository at this point in the history
  2. Resolve semicolon_if_nothing_returned pedantic clippy lint from PR 1127

        warning: consider adding a `;` to the last statement for consistent formatting
           --> src/map.rs:377:9
            |
        377 |         self.map.hash(state)
            |         ^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.map.hash(state);`
            |
            = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
            = note: `-W clippy::semicolon-if-nothing-returned` implied by `-W clippy::pedantic`
            = help: to override `-W clippy::pedantic` add `#[allow(clippy::semicolon_if_nothing_returned)]`
    dtolnay committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    0af2bda View commit details
    Browse the repository at this point in the history
  3. Touch up PR 1127

    dtolnay committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    5e7bedc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    51d94eb View commit details
    Browse the repository at this point in the history
  5. Release 1.0.118

    dtolnay committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    c4f24f3 View commit details
    Browse the repository at this point in the history
Loading