-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add disable authentication option #310
Conversation
btw I had difficulty in getting the app to build with the instructions in the README. |
Thanks for submitting this PR, I'll take a look at it as soon as I can! I know the depencies might be a little outdated 😬😬 |
hi, I've thought about this PR for the past couple of days and I think it's not the correct approach to solve this problem. In my opinion VueTorrent should check if it needs to authenticate before displaying the login page. For example, if you have set up bypass_local_auth or bypass_auth_subnet_whitelist_enabled, qbittorrent doesn't require authentication to access its API if you're within the scope of the bypass, so it doesn't make sense to serve a login page in these cases. I'll try to come up with a different solution but it might take some time since I'm not familiar with Vue. |
I've updated the PR. |
Looks like a good solution! |
feat: Add disable authentication option
Adds a toggle option to disable the authentication by making the isAuthenticated function return true if the option is set in the UI and the user is already authenticated.
Solves #152 and #266
PR Checklist