| Lists: | pgsql-hackers |
|---|
| From: | Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru> |
|---|---|
| To: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | postgresql.conf.sample missing units |
| Date: | 2021-07-19 09:44:50 |
| Message-ID: | f10d16fc-8fa0-1b3c-7371-cb3a35a13b7a@postgrespro.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hello,
I found that the start section of the postgresql.conf file is missing a
description of two units: bytes (appeared in version 11) and
microseconds (in version 12).
The attached patch makes these changes to the postgresql.conf.sample file.
--
Pavel Luzanov
Postgres Professional: https://postgrespro.com
The Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| add-units-in-sample.patch | text/x-patch | 795 bytes |
| From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
|---|---|
| To: | Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: postgresql.conf.sample missing units |
| Date: | 2021-07-19 14:31:37 |
| Message-ID: | CAFBsxsEu3QrFibzNNctNbECxQJ9HXB+Xo1+438BUnLE1EWk2Rw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Mon, Jul 19, 2021 at 5:44 AM Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru>
wrote:
>
> Hello,
>
> I found that the start section of the postgresql.conf file is missing a
> description of two units: bytes (appeared in version 11) and
> microseconds (in version 12).
>
> The attached patch makes these changes to the postgresql.conf.sample file.
Seems like an oversight. I'll commit this soon barring objections.
--
John Naylor
EDB: http://www.enterprisedb.com
| From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
|---|---|
| To: | Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: postgresql.conf.sample missing units |
| Date: | 2021-07-21 14:33:16 |
| Message-ID: | CAFBsxsF60iJW7=SkOtyVf6R0iWmTruhgMy36u=NMMHKrkRUNNw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Mon, Jul 19, 2021 at 10:31 AM John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
wrote:
>
> On Mon, Jul 19, 2021 at 5:44 AM Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru>
wrote:
> >
> > Hello,
> >
> > I found that the start section of the postgresql.conf file is missing a
> > description of two units: bytes (appeared in version 11) and
> > microseconds (in version 12).
> >
> > The attached patch makes these changes to the postgresql.conf.sample
file.
>
> Seems like an oversight. I'll commit this soon barring objections.
I pushed this and backpatched to v12. I also extracted just the "bytes"
part and applied it to v11.
--
John Naylor
EDB: http://www.enterprisedb.com
| From: | Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru> |
|---|---|
| To: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: postgresql.conf.sample missing units |
| Date: | 2021-07-22 10:14:19 |
| Message-ID: | ee4d4450-183f-2663-1432-e0fb889bb483@postgrespro.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 21.07.2021 17:33, John Naylor wrote:
> I pushed this and backpatched to v12. I also extracted just the
> "bytes" part and applied it to v11.
It's a little more complicated, but it's the right decision.
Thank you.
Pavel Luzanov
Postgres Professional: https://postgrespro.com
The Russian Postgres Company