-
-
Notifications
You must be signed in to change notification settings - Fork 131
fix: Tauri setup command errors with string escaping on Windows with Bun #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: Tauri setup command errors with string escaping on Windows with Bun #355
Conversation
|
WalkthroughThe setup logic for invoking the Tauri CLI in the project has been refactored to handle a special case: when running on Windows with the "bun" package manager, the command execution method changes from a shell command string to a direct executable with arguments. Common argument construction and variable reuse have been improved. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🧬 Code Graph Analysis (1)apps/cli/src/helpers/setup/tauri-setup.ts (1)
🔇 Additional comments (6)
|
6227ae8
to
864e863
Compare
d52a083
to
fcbdd0d
Compare
For some reason, when running the generator with the Tauri setup, bunx encounters an issue with parsing the arg command string (eg.
--before-dev-build="bun run dev"
).This is happening only on Windows (powershell) with Bun. So I added a check in tauri-setup for that specific setup and used direct arguments without shell execution. Not sure if this is something Bun has to fix on their end as pnpm and npm works with no issues. Regardless of that, this PR introduces a workaround to the issue.
Summary by CodeRabbit