Skip to content

fix(cli): add "--editors none" and "--rules none" when no options selected in ultracite #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AmanVarshney01
Copy link
Owner

@AmanVarshney01 AmanVarshney01 commented Jul 29, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Ensured that when no editors or rules are selected, the ultracite command now explicitly includes "--editors none" and "--rules none" flags. This provides clearer behavior and avoids ambiguity during setup.

Copy link

changeset-bot bot commented Jul 29, 2025

🦋 Changeset detected

Latest commit: ba3a2f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-better-t-stack Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jul 29, 2025

Walkthrough

A patch was introduced to modify the behavior of the ultracite command in the setup process. Now, when no editors or rules are selected by the user, the command explicitly includes the flags --editors none and --rules none. No changes were made to exported or public entity declarations.

Changes

Cohort / File(s) Change Summary
Changeset Documentation
.changeset/lucky-peas-hope.md
Documents the patch that updates ultracite command behavior for cases with no selected editors or rules.
Ultracite Setup Logic
apps/cli/src/helpers/setup/ultracite-setup.ts
Updates setupUltracite to append --editors none and --rules none flags when no options are selected.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CLI
    participant Ultracite

    User->>CLI: Run setupUltracite (no editors/rules selected)
    CLI->>CLI: Check editors and rules arrays
    alt No editors selected
        CLI->>CLI: Add --editors none to args
    end
    alt No rules selected
        CLI->>CLI: Add --rules none to args
    end
    CLI->>Ultracite: Invoke ultracite with updated args
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

A patch for ultracite, neat and small,
Adds "none" to editors, rules, and all.
No more guessing what to do—
The flags are clear, the path is true!
With every hop, the setup’s bright,
Thanks to this change, all runs right.
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 806e059 and ba3a2f8.

📒 Files selected for processing (2)
  • .changeset/lucky-peas-hope.md (1 hunks)
  • apps/cli/src/helpers/setup/ultracite-setup.ts (1 hunks)
🔇 Additional comments (3)
apps/cli/src/helpers/setup/ultracite-setup.ts (2)

98-100: LGTM! Explicit handling for empty editor selection.

The addition of the else block correctly ensures that when no editors are selected, the ultracite command explicitly includes --editors none, making the command's behavior more predictable and explicit.


104-106: LGTM! Explicit handling for empty rules selection.

The addition of the else block correctly ensures that when no rules are selected, the ultracite command explicitly includes --rules none, maintaining consistency with the editor handling and fulfilling the PR objective.

.changeset/lucky-peas-hope.md (1)

1-6: LGTM! Changeset documentation is accurate.

The changeset correctly documents this as a patch-level change to the "create-better-t-stack" package with an accurate description that matches the PR objective.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch aman/fix-ultracite-none

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

pkg-pr-new bot commented Jul 29, 2025

Open in StackBlitz

npx https://pkg.pr.new/AmanVarshney01/create-better-t-stack@433

commit: ba3a2f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant