-
-
Notifications
You must be signed in to change notification settings - Fork 131
Remove new line in rules, Remove duplicate Roo option #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
WalkthroughThis change removes the "Roo" editor entry from a CLI helper constant and corrects a line break in a markdown template for addon instructions, merging a split command example into a single line. No modifications to logic, control flow, or public API declarations were made. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
apps/cli/templates/addons/vibe-rules/.bts/rules.md.hbs (1)
101-104
: Broken command in fenced block — merge into a single line for copy-pasteThe add command is split across two lines, which will break when users copy-paste. Merge into one line to match the new bullet and the PR objective.
Apply this diff:
```bash -{{#if (eq packageManager "bun")}}bunx{{else if (eq packageManager "pnpm")}}pnpx{{else}}npx{{/if}} create-better-t-stack -add +{{#if (eq packageManager "bun")}}bunx{{else if (eq packageManager "pnpm")}}pnpx{{else}}npx{{/if}} create-better-t-stack add</blockquote></details> </blockquote></details> <details> <summary>🧹 Nitpick comments (1)</summary><blockquote> <details> <summary>apps/cli/templates/addons/vibe-rules/.bts/rules.md.hbs (1)</summary><blockquote> `97-106`: **Avoid duplication of the same command in two places** You now show the same add command in both a fenced block and a bullet. Consider keeping just one, or extract the conditional runner prefix into a reusable partial to prevent future drift. Also applies to: 131-131 </blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between ea908ddc86e874b9456a660bf2904481a2d3af5f and 457217bfd4a27814c906178ab198602061b1a568. </details> <details> <summary>📒 Files selected for processing (2)</summary> * `apps/cli/src/helpers/setup/vibe-rules-setup.ts` (0 hunks) * `apps/cli/templates/addons/vibe-rules/.bts/rules.md.hbs` (1 hunks) </details> <details> <summary>💤 Files with no reviewable changes (1)</summary> * apps/cli/src/helpers/setup/vibe-rules-setup.ts </details> <details> <summary>🔇 Additional comments (1)</summary><blockquote> <details> <summary>apps/cli/templates/addons/vibe-rules/.bts/rules.md.hbs (1)</summary> `131-131`: **LGTM — clear, single-line instruction** Good addition; consistent conditional runner and single-line copy-pasteable command. </details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
From what I tested, the cli options roo and cline/roo creates the same files. Or maybe I was mistaken about it, correct me if I am wrong. |
Summary by CodeRabbit
Bug Fixes
Chores