Skip to content

Site Overview: Add manage contact info to domain card #105107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: DOTDASH-250/domains-card-manage-dns
Choose a base branch
from
Open

Site Overview: Add manage contact info to domain card #105107

wants to merge 1 commit into from

Conversation

arthur791004
Copy link
Contributor

Part of DOTDASH-249

Proposed Changes

  • Implement Manage contact information action to the domain dataviews on domain card

Why are these changes being made?

Testing Instructions

  • Go to /v2/sites/:site on your site with custom domain
  • Click the ... on the custom domain on the domain card
  • Click Manage contact information
  • Ensure it opens the Manage contact information page

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2025 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-152079
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-152079&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-152079&env=a8c-for-agencies

@matticbot
Copy link
Contributor

matticbot commented Aug 7, 2025 •
edited
Loading

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug DOTDASH-249/domains-card-manage-contact-info on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Aug 7, 2025 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~151 bytes added 📈 [gzipped])

name                    parsed_size           gzip_size
entry-dashboard-dotcom       +125 B  (+0.0%)      +76 B  (+0.0%)
entry-dashboard-a4a          +125 B  (+0.0%)      +74 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~164 bytes added 📈 [gzipped])

name                parsed_size           gzip_size
sites-dashboard          +125 B  (+0.0%)      +81 B  (+0.0%)
site-settings            +125 B  (+0.0%)      +83 B  (+0.0%)
site-performance         +125 B  (+0.0%)      +81 B  (+0.0%)
site-monitoring          +125 B  (+0.0%)      +81 B  (+0.0%)
site-logs                +125 B  (+0.0%)      +81 B  (+0.0%)
overview                 +125 B  (+0.0%)      +81 B  (+0.0%)
hosting                  +125 B  (+0.0%)      +81 B  (+0.0%)
github-deployments       +125 B  (+0.0%)      +81 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~80 bytes added 📈 [gzipped])

name                       parsed_size           gzip_size
async-load-v-2-sites-list       +125 B  (+0.0%)      +80 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@arthur791004 arthur791004 force-pushed the DOTDASH-249/domains-card-manage-contact-info branch from 06506ca to e8ce4a5 Compare August 7, 2025 12:53
@arthur791004 arthur791004 self-assigned this Aug 7, 2025
@arthur791004 arthur791004 marked this pull request as ready for review August 7, 2025 12:53
@arthur791004 arthur791004 requested a review from a team as a code owner August 7, 2025 12:53
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 7, 2025
@arthur791004 arthur791004 force-pushed the DOTDASH-249/domains-card-manage-contact-info branch from e8ce4a5 to e69c6a7 Compare August 7, 2025 13:05
arthur791004
arthur791004 commented Aug 7, 2025
View reviewed changes
client/dashboard/data/domains.ts
@@ -6,7 +6,6 @@ export type { DomainSuggestion, DomainSuggestionQuery };

export const DomainTypes = {
MAPPED: 'mapping',
REGISTERED: 'registered',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is computed domain type by ! wpcom_domain && has_registration. Try to get rid of it and use the raw data to determine whether the domain is registered.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why? It's already provided by the backend; why do the computation again?

@arthur791004 arthur791004 requested a review from a team August 7, 2025 13:28
fushar
fushar reviewed Aug 8, 2025
View reviewed changes
client/dashboard/domains/index.tsx
@@ -19,7 +19,7 @@ export function getDomainId( domain: Domain ): string {
function Domains() {
const { user } = useAuth();
const fields = useFields();
const actions = useActions( { user } );
const actions = useActions( { user, supportsBulk: true } );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's in the scope of this PR; but I can't seem to use bulk selection in this top-level Domains screen 🤔

client/dashboard/data/domains.ts
@@ -6,7 +6,6 @@ export type { DomainSuggestion, DomainSuggestionQuery };

export const DomainTypes = {
MAPPED: 'mapping',
REGISTERED: 'registered',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why? It's already provided by the backend; why do the computation again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fushar fushar fushar left review comments

Assignees

@arthur791004 arthur791004

Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arthur791004 @matticbot @fushar