-
Notifications
You must be signed in to change notification settings - Fork 2k
Sync Modal: improve layout and spacing for better fit on smaller screens #105109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Async-loaded Components (~8 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
I think this needs designer eyes @Marinatsu 👀 . I have tested it and the scroll starts at around 750px height:
|
Thanks for testing @epeicher ! I asked for the design feedback in p1754640213303199-slack-C04GESRBWKW . |
Closes DOTCOM-14140
Proposed Changes
This PR reduces spacing around the Sync modal to make the items a bit more compact and smaller screen friendly.
Before
After
Observe that we have no scrollbar here and all the content fits when you open at least the first set of options.
Testing Instructions
/staging-site/{yourAtomicSite}
Sync
button to open the sync modalPre-merge Checklist