Skip to content

Add domain action Transfer to WP.com #105145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Add domain action Transfer to WP.com #105145

wants to merge 1 commit into from
+15 −2

Conversation

taipeicoder
Copy link
Contributor

@taipeicoder taipeicoder commented Aug 9, 2025 •
edited
Loading

Ref DOTDASH-248

Proposed Changes

Logic copied from

wp-calypso/packages/domains-table/src/domains-table/domains-table-row-actions.tsx

Lines 148 to 155 in 607168e

canTransferToWPCOM && (
<MenuItemLink
key="transferToWPCOM"
onClick={ handleMenuItemClick }
href={ domainUseMyDomain( siteSlug, domain.name, useMyDomainInputMode.transferDomain ) }
>
{ __( 'Transfer to WordPress.com' ) }
</MenuItemLink>

wp-calypso/client/my-sites/domains/domain-management/dataviews/use-actions.tsx

Lines 177 to 198 in 607168e

id: 'transfer-domain',
callback: ( domains: Array< PartialDomainData > ) => {
const domain = domains.length > 0 && domains[ 0 ];
if ( domain ) {
const url = domainUseMyDomain(
getSiteSlug( domain ),
domain.domain,
useMyDomainInputMode.transferDomain
);
navigate( url );
}
},
label: translate( 'Transfer to WordPress.com' ),
supportsBulk: false,
isEligible( partialDomain: PartialDomainData ) {
const domain = getFullDomain( partialDomain );
if ( ! domain ) {
return false;
}
return domain.type === domainTypes.MAPPED && domain.isEligibleForInboundTransfer;
},
},

Why are these changes being made?

Site Overview v2 development

Testing Instructions

I'm not sure how to test this other than comparing it to the logic it's based on. Given that it's redirecting to the domain transfer flow, checking that the logic is sound should be good enough.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@taipeicoder taipeicoder self-assigned this Aug 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2025 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-152235
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-152235&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-152235&env=a8c-for-agencies

@taipeicoder taipeicoder marked this pull request as ready for review August 9, 2025 05:20
@taipeicoder taipeicoder requested a review from a team as a code owner August 9, 2025 05:20
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@taipeicoder taipeicoder

Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taipeicoder @matticbot