performance (XLStyle): Custom GetHashCode to improve performance on XLStyle structs #2677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LStyle. structs. Slight reduction in memory allocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Custom GetHashCode to improve performance on XLStyle structs Slight reduction in memory allocation. vs using
HashCode()Benchmarks
NOTE: These benchmarks are from when I stacked this PR ontop of #2674 and execute the benchmark test in that PR, but it does illustrate the change.
Before
After GetHashCode Changes.
Why HashCode may be slower
It has extra state and indirection
HashCode is a mutable struct that maintains internal buffers
Each .
Add()writes into the bufferWhen calling
.ToHashCode()→ it combines state + random salt → extra CPU cost