Fix loading Excel files with pictures having forbidden characters in names #2716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…names Allow loading Excel files that contain pictures with names having characters that ClosedXML normally forbids (like backslash, colon, etc). This commonly occurs when loading files created by other applications. - Add optional validateName parameter to XLPicture.SetName method - Skip validation when loading pictures from existing Excel files - Maintain validation for user-created pictures through public API - Add comprehensive unit tests for the new functionality Fixes issue where files with picture names like "Picture@01\QPosted@" couldn't be loaded. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
5 tasks
|
Hi @jahav, @igitur, @Pankraty, I've created issue #2727 with a reproducible test case for this bug. This PR fixes The fix is minimal - it just removes the overly restrictive validation during loading Would appreciate a review when you have time. Happy to make any adjustments needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow loading Excel files that contain pictures with names having characters that ClosedXML normally forbids (like backslash, colon, etc). This commonly occurs when loading files created by other applications.
Fixes issue where files with picture names like "Picture@01\QPosted@" couldn't be loaded.