Remove Divisor from Downward API resrouceFieldRefs #4231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means CPU and memory information will now be exposed using the default divisor for CPU and memory (with default being "1" for both). This means memory information will now be represented in bytes, as expected by pgMonitor and the CPK Metrics & Monitoring stack when consuming Downward API information. Issue: PGO-2604
867e83c to
114fcea
Compare
|
The default divisor is "1" (reasonable) but in reconcile_test.go, it looks like "0" (maddening)? |
|
@benjaminjb agreed! Looks like without a full Kube running we won't get the default of |
benjaminjb
approved these changes
Aug 6, 2025
|
Just noting that I tested this with the monitoring stack, and everything looks good. E.g. for this spec: apiVersion: postgres-operator.crunchydata.com/v1beta1
kind: PostgresCluster
metadata:
name: hippo
namespace: postgres-operator
spec:
instrumentation: {}
postgresVersion: 17
instances:
- name: instance1
replicas: 2
resources:
requests:
cpu: 1
memory: "1Gi"
dataVolumeClaimSpec:
accessModes:
- "ReadWriteOnce"
resources:
requests:
storage: 1GiI see this on the file system: $ cat mem_request
1073741824
$ cat cpu_request
1And then the dashboard accurately reflects the memory reqiest: 
|
|
@benjaminjb agreed, release notes should be sufficient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
divisorfrom Downward API resrouceFieldRefs. This means CPU and memory information will now be exposed using the default divisor for CPU and memory (with default being "1" for both). This means memory information will now be represented in bytes, as expected by pgMonitor and the CPK Metrics & Monitoring stack when consuming Downward API information.Checklist:
Type of Changes:
Fixes memory metrics in the Metrics & Monitoring stack.
What is the current behavior (link to any open issues here)?
The divisor for the Downward API volumes for CPU and memory defaults to
1mfor CPU and1Mifor memory.What is the new behavior (if this is a feature change)?
Potential breaking behavior if anyone is consuming Downward API info via a custom sidecar.
Other Information:
Issue: PGO-2604