Add HashContext and HashProvider for managing URL hash state #3541
Conversation
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR implements a HashContext and HashProvider system to properly manage URL hash state changes for same-page links. The existing useHash hook was not triggering updates when clicking links with hashes on the same page, so this solution replaces the previous implementation with a context-based approach that manually tracks hash changes through the Link component.
- Replaces the existing
useHashhook implementation with a context-based solution - Adds HashProvider to the application's root context providers
- Integrates hash tracking into the Link component's onClick handler
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/gitbook/src/components/primitives/Link.tsx | Adds HashContext integration and calls updateHashFromUrl in onClick handler |
| packages/gitbook/src/components/hooks/useHash.tsx | New file implementing HashContext, HashProvider, and updated useHash hook |
| packages/gitbook/src/components/hooks/useHash.ts | Removes the old useHash implementation |
| packages/gitbook/src/components/RootLayout/ClientContexts.tsx | Wraps the app with HashProvider |
ad7ccc0 to
51539e3
Compare
Link with an hash on the same page were not triggering change from the
useHashhook.