Support new coverDefinitionDark for cards & image type #3547
+161
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dbb4d2f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a new coverDefinitionDark field for table view cards, enabling different cover images for light and dark themes. The changes also introduce a new image column type for table records.
- Add
getRecordCardCoversutility function to extract both light and dark cover images - Implement new image column type with proper image display and linking
- Update RecordCard component to handle dark theme covers with responsive layout considerations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/gitbook/src/components/DocumentView/Table/utils.ts |
Adds getRecordCardCovers function and imports for new dark cover support |
packages/gitbook/src/components/DocumentView/Table/RecordColumnValue.tsx |
Implements new image column type with proper image rendering and link handling |
packages/gitbook/src/components/DocumentView/Table/RecordCard.tsx |
Updates card rendering to support both light and dark covers with responsive behavior |
.changeset/serious-pumas-clap.md |
Documents the feature addition for changelog generation |
packages/gitbook/src/components/DocumentView/Table/RecordCard.tsx
Outdated
Show resolved
Hide resolved
e7036d4 to
529f65d
Compare
529f65d to
f3857be
Compare
f3857be to
d42767b
Compare
emmerich
reviewed
Aug 8, 2025
packages/gitbook/src/components/DocumentView/Table/RecordCard.tsx
Outdated
Show resolved
Hide resolved
7ddeede to
c9b426d
Compare
emmerich
reviewed
Aug 8, 2025
packages/gitbook/src/components/DocumentView/Table/RecordColumnValue.tsx
Outdated
Show resolved
Hide resolved
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
emmerich
approved these changes
Aug 8, 2025
2a194a9 to
0246fb1
Compare
0246fb1 to
3139837
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.