Skip to content

Keywords/NewKeywords: minor code simplification #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Jul 6, 2025

⚠️ This PR needs for PR #1806 to be merged first to allow CI to pass. ⚠️ (PR #1806 has been merged)


Follow up on #1791

Now support for PHPCS < 3.13.0 has been dropped, some cross-version compatibility code can be dropped from this sniff.

@jrfnl jrfnl added this to the 10.0.0 milestone Jul 6, 2025
@jrfnl jrfnl requested a review from wimg July 6, 2025 02:06
@jrfnl jrfnl added chores/QA PR: quick merge PR only contains relatively simple changes PR: ready for review labels Jul 6, 2025
Base automatically changed from feature/composer-update-for-phpcsutils-1.1.0 to develop July 6, 2025 13:28
Follow up on 1791

Now support for PHPCS < 3.13.0 has been dropped, some cross-version compatibility code can be dropped from this sniff.
@jrfnl jrfnl force-pushed the feature/newkeywords-minor-simplification branch from 13ae670 to 866bc8f Compare July 6, 2025 13:41
@jrfnl
Copy link
Member Author

jrfnl commented Jul 6, 2025

Rebased without changes after the merge of #1806 and marked as "ready for review".

@jrfnl jrfnl marked this pull request as ready for review July 6, 2025 13:41
@wimg wimg merged commit 9a3e6cb into develop Aug 6, 2025
46 checks passed
@wimg wimg deleted the feature/newkeywords-minor-simplification branch August 6, 2025 19:21
@github-actions github-actions bot removed PR: quick merge PR only contains relatively simple changes PR: ready for review labels Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants