Use a dedicated configuration directory path for all-users profiles on non-windows systems. #25748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Canonical Ltd." |
Currently the all-users profiles are stored in the
installation directory. Unix-based systems and
derivatives mostly follow recommendations of the
Filesystem Hierarchy Standard [FHS]. The FHS
recommends to place configuration files into the
/etc directory.
For example, here are the locations of the system
wide configuration files of other popular shells:
- bash(1): /etc/bash.bashrc (Debian/Ubuntu) or
/etc/bashrc (RedHat/Fedora)
- zsh(1): /etc/zshrc
- fish(1): /etc/fish/config.fish
I took inspiration from where NuGet is locating its
system-wide configuration, see [NuGet config file locations]:
This commit introduces the environment variable
`POWERSHELL_COMMON_APPLICATION_DATA`.
If this variable is neither null nor empty, then
this location is used. This allows distros that do
not follow the FHS to customize the location.
On Windows PowerShell keeps using the installation directory.
On macOS PowerShell uses the `/Library/Application Support/PowerShell` directory.
Otherwise PowerShell uses `/etc/opt/powershell`.
[FHS]: https://refspecs.linuxfoundation.org/FHS_3.0/fhs/index.html
[NuGet config file locations]: https://learn.microsoft.com/en-us/nuget/consume-packages/configuring-nuget-behavior#config-file-locations-and-uses
Fixes: PowerShell#20336, PowerShell#25007
Signed-off-by: Dominik Viererbe <dominik.viererbe@canonical.com>
"IO.Path" instead of "io.path" Signed-off-by: Dominik Viererbe <dominik.viererbe@canonical.com>
Signed-off-by: Dominik Viererbe <dominik.viererbe@canonical.com>
5705b00 to
00393a6
Compare
|
Rebased onto master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PowerShell should search in a dedicated directory (other than the installation directory) for the all-users profile to adhere to the Filesystem Hierarchy Standard (FHS).
PR Context
Currently the all-users profiles are stored in the installation directory. Unix-based systems and derivatives mostly follow recommendations of the FHS. The FHS recommends to place configuration files into the
/etcdirectory.For example, here are the locations of the system wide configuration files of other popular shells:
/etc/bash.bashrc(Debian/Ubuntu) or/etc/bashrc(RedHat/Fedora)/etc/zshrc/etc/fish/config.fishI took inspiration from where NuGet is locating its system-wide configuration, see NuGet config file locations:
This commit introduces the environment variable
POWERSHELL_COMMON_APPLICATION_DATA.If this variable is neither null nor empty, then this location is used. This allows distros that do not follow the FHS to customize the location.
/Library/Application Support/PowerShelldirectory./etc/opt/powershell.This change is also needed to make the all-users profile usable when installing powershell via a snap, see canonical/powershell-snaps#14
Fixes: #20336, #25007
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header