Remove eager initialization of _startupScripts to enable lazy thread-safe initialization
#25767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-safe initialization The field `_startupScripts` was being initialized at declaration, which prevented the `Interlocked.CompareExchange` logic in the `StartupScripts` property from ever executing. This change removes the eager initialization to allow proper lazy and thread-safe setup of the HashSet when the property is first accessed.
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
@iSazonov Could you please review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field
_startupScriptswas being initialized at declaration, which prevented theInterlocked.CompareExchangelogic in theStartupScriptsproperty from ever executing.This change removes the eager initialization to allow proper lazy and thread-safe setup
of the
HashSetwhen the property is first accessed.