Add property and event for debug attach #25788
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `IsRemoteDebuggerAttached` property to `Runspace` that indicates whether a debugger is attached to the Runspace through the `Debug-Runspace` cmdlet. Also adds a new engine event `PowerShell.OnDebugAttach` that is emitted when the debugger is attached.
This was referenced Jul 29, 2025
iSazonov
approved these changes
Jul 29, 2025
kilasuit
reviewed
Jul 29, 2025
I debated adding it internally and I couldn't think of a scenario where an end user would want to wait for a detach before continuing. But in saying that if there is something I haven't thought off I can definitely add it. |
|
Lets leave adding that as a future enhancement for now as it seems to be small enough a change that should be a good win for someone else coming to the repo looking to contribute. |
kilasuit
approved these changes
Jul 29, 2025
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Adds the
IsRemoteDebuggerAttachedproperty toRunspacethat indicates whether a debugger is attached to the Runspace through theDebug-Runspacecmdlet. Also adds a new engine eventPowerShell.OnDebugAttachthat is emitted when the debugger is attached.PR Context
Fixes: #21392
Also see PowerShell/PowerShellEditorServices#2250 which is the driver behind the new event. Unfortunately the only safe way to notify that code is safe to continue and a debugger is attached is through PowerShell. Sending our own event before calling
Debug-Runspacewon't work because the code could continue beforeDebug-Runspacehas set itself up. We cannot send an event after because the runspace will be busy runningDebug-Runspace.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header