work

WebAssembly · kripken · May 15, 2025 · May 15, 2025 · May 15, 2025 · May 15, 2025
commit adad0dc0091fe2cd67c9f78ed1d65fa8e51dbe85
diff --git a/src/pass.h b/src/pass.h
@@ -330,7 +330,7 @@ struct PassRunner {
     bool first = false;
     bool last = false;
   };
-  static const UnknownOrdering;
+  static const Ordering UnknownOrdering;
 
   // Adds the default set of optimization passes; this is what -O does.
   //

diff --git a/src/wasm-binary.h b/src/wasm-binary.h
@@ -454,6 +454,7 @@ extern const char* FP16Feature;
 extern const char* BulkMemoryOptFeature;
 extern const char* CallIndirectOverlongFeature;
 extern const char* CustomDescriptorsFeature;
+extern const char* StringBuiltinsFeature;
 
 enum Subsection {
   NameModule = 0,

diff --git a/src/wasm/wasm-binary.cpp b/src/wasm/wasm-binary.cpp
@@ -1395,6 +1395,8 @@ void WasmBinaryWriter::writeFeaturesSection() {
         return BinaryConsts::CustomSections::CallIndirectOverlongFeature;
       case FeatureSet::CustomDescriptors:
         return BinaryConsts::CustomSections::CustomDescriptorsFeature;
+      case FeatureSet::StringBuiltins:
+        return BinaryConsts::CustomSections::StringBuiltinsFeature;
       case FeatureSet::None:
       case FeatureSet::Default:
       case FeatureSet::All:

diff --git a/src/wasm/wasm.cpp b/src/wasm/wasm.cpp
@@ -61,6 +61,7 @@ const char* FP16Feature = "fp16";
 const char* BulkMemoryOptFeature = "bulk-memory-opt";
 const char* CallIndirectOverlongFeature = "call-indirect-overlong";
 const char* CustomDescriptorsFeature = "custom-descriptors";
+const char* StringBuiltinsFeature = "string-builtins";
 
 } // namespace BinaryConsts::CustomSections
 

diff --git a/test/unit/test_features.py b/test/unit/test_features.py
@@ -453,4 +453,5 @@ def test_emit_all_features(self):
             '--enable-bulk-memory-opt',
             '--enable-call-indirect-overlong',
             '--enable-custom-descriptors',
+            '--enable-string-builtins',
         ], p2.stdout.splitlines())