Skip to content

feat(forms): switch to RegExp in pattern validator #63045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 8, 2025
Merged

feat(forms): switch to RegExp in pattern validator #63045

merged 4 commits into from
Aug 8, 2025

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Aug 7, 2025

Finishes up & closes #62671

@NothingEverHappens @mmalerba
feat(forms): switch to RegExp in pattern validator
2b5ed73 
No other libraries use string patterns for validation
@mmalerba mmalerba requested review from leonsenft and kirjs August 7, 2025 05:51
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: docs Related to the documentation area: forms target: feature This PR is targeted for a feature branch (outside of main and semver branches) labels Aug 7, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 7, 2025
mmalerba added 3 commits August 7, 2025 15:08
@mmalerba
refactor(forms): update PATTERN to refer to a RegExp
9abe9bb 
addresses feedback from the original PR
@mmalerba
docs(forms): update docs for pattern logic function
6182244 
aligns the tsdoc with other validatior logic functions
@mmalerba
build: update api goldens
6bbd3cd 
updates the api goldens to reflect changes in this PR
@pullapprove pullapprove bot requested review from atscott and thePunderWoman August 7, 2025 06:09
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Aug 7, 2025
@pullapprove pullapprove bot requested a review from devversion August 7, 2025 10:36
devversion
devversion approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from kirjs August 7, 2025 13:48
@mmalerba mmalerba merged commit e127c42 into angular:prototype/signal-forms Aug 8, 2025
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devversion devversion devversion approved these changes

@leonsenft leonsenft Awaiting requested review from leonsenft

@atscott atscott Awaiting requested review from atscott

@thePunderWoman thePunderWoman Awaiting requested review from thePunderWoman

@kirjs kirjs Awaiting requested review from kirjs

Assignees
No one assigned
Labels
area: build & ci Related the build and CI infrastructure of the project area: docs Related to the documentation area: forms detected: feature PR contains a feature commit target: feature This PR is targeted for a feature branch (outside of main and semver branches)
Projects
Experimental Signal Forms
Status: Done
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @kirjs @devversion @NothingEverHappens