feat(python): support xlang metashare (WIP) #2278
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…options, add Buffer::write_uint8
chaokunyang
reviewed
Jun 3, 2025
| SCHEMA_CONSISTENT = 1 | ||
| COMPATIBLE = 2 | ||
|
|
||
| class MetaContext: |
There was a problem hiding this comment.
We'd better to put this class in _serialization.pyx for better performance
|
It would be great if we could change all class_ prefix to type_, like class_info -> type_info, class_resolver -> type_resolver. This will make the code more clean. How about opening another PR for this? After that PR is merged, we could merge from main branch again to resovle the conflicts |
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prepare to implement xlang metashare encode&decode in pyfory.
Now finish
field_infoandtype_info(TypeDef)in python not cython.I will continue to finish type_resolver for registry.
other small change:
Buffer::write_uint8for writing 1 byte header.Some Question
class_prefix totype_, likeclass_info -> type_info,class_resolver -> type_resolver. So it will be unified.writeVarUint32Small7in pyfury cython. Now I usewrite_varuint32. Should I add this function?xread/xwritelogic intype_info/field_infoclass. If this is not good, I will rewrite this part.Related issues
#2160
Does this PR introduce any user-facing change?
WIP
Benchmark
TODO