Skip to content

chore(java): Remove redundant code #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(java): Remove redundant code #2375

wants to merge 2 commits into from

Conversation

LiangliangSui
Copy link
Contributor

What does this PR do?

Related issues

Does this PR introduce any user-facing change?

  • Does this PR introduce any public API change?
  • Does this PR introduce any binary protocol compatibility change?

Benchmark

@LiangliangSui
chore(java): Remove redundant code
4430cd1 
Signed-off-by: Liangliang Sui <coolsui.coding@gmail.com>
chaokunyang
chaokunyang reviewed Jul 4, 2025
View reviewed changes
java/fory-core/src/main/java/org/apache/fory/serializer/SerializationBinding.java
buffer.writeByte(NOT_NULL_VALUE_FLAG);
writeNonRef(buffer, obj);
}
fory.writeNullable(buffer, obj);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually inline have better performance. JVM JIT nto always inline those calls

@LiangliangSui
Copy link
Contributor Author

Does readNullable also need to be manually inline?

fory/java/fory-core/src/main/java/org/apache/fory/serializer/SerializationBinding.java

Lines 381 to 384 in a9e5d99

@Override
public Object readNullable(MemoryBuffer buffer, Serializer<Object> serializer) {
return fory.xreadNullable(buffer, serializer);
}

@chaokunyang
Copy link
Collaborator

Does readNullable also need to be manually inline?

fory/java/fory-core/src/main/java/org/apache/fory/serializer/SerializationBinding.java

Lines 381 to 384 in a9e5d99

@Override
public Object readNullable(MemoryBuffer buffer, Serializer<Object> serializer) {
return fory.xreadNullable(buffer, serializer);
}

Yes, we'd better do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaokunyang chaokunyang chaokunyang left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LiangliangSui @chaokunyang