chore(Scala): add Scala PolymorphicTest #2378
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
commented
Jul 4, 2025
| } | ||
| "serialize/deserialize circle class (Java object format - shape hint)" ignore { | ||
| val c = Circle(5.0) | ||
| fory.deserializeJavaObject(fory.serializeJavaObject(c), classOf[Shape]) shouldEqual c |
There was a problem hiding this comment.
test fails - so set to ignore
There was a problem hiding this comment.
For polymorphicc class, fory needs final class be passed. Or use serialize/deserialize app i directly
There was a problem hiding this comment.
I'm using the plain serialize/deserialize in practice but I thought I'd try serializeJavaObject/deserializeJavaObject to see how they worked.
There was a problem hiding this comment.
deserializeJavaObject needs teh exact concreate type be passed. Actually I think we can provide better error message here if wrong type is passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It wasn't clear from the docs how Fory handled polymorphism.
The final test fails, so I set it to be ignored. deserializeJavaObject does not work if the class you pass to it is a superclass.
Related issues
Does this PR introduce any user-facing change?
Benchmark