Skip to content

fix: serve static files from pwa if not found in api #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: serve static files from pwa if not found in api #2710

wants to merge 2 commits into from

Conversation

ibousfiha
Copy link

Hi, this PR is to serve static files like svgs from pwa if not found in api.
Please let me know if it fits or updates are required.

Q A
Branch? main
Tickets Closes #..., closes #...
License MIT
Doc PR api-platform/docs#...

@soyuka soyuka requested a review from dunglas November 6, 2024 21:50
@dunglas
Copy link
Member

dunglas commented Nov 25, 2024

Good idea, but this will prevent the API from serving files with this extension if any.

We should use try_files to first check if the file exists API-side, and redirect to the PWA if it's not the case. This will have the added benefit of working with any file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas Awaiting requested review from dunglas

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibousfiha @dunglas