Add toolchain plugin everywhere and unify plugin style #1355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Configure project :testkit:gradle-testkit-plugin Using a toolchain installed via auto-provisioning, but having no toolchain repositories configured. This behavior is deprecated. Consider defining toolchain download repositories, otherwise the build might fail in clean environments; see https://docs.gradle.org/8.11-rc-3/userguide/toolchains.html#sub:download_repositoriesed artifacts.
There was a problem hiding this comment.
Latest version is 1.0.0.
I'm going through some old PRs (sorry, I was very busy for a while). Unfortunately I don't think I can merge this right now given there's currently an outage related to foojay. I'll come back to this later.
|
Sounds fun, want me to resolve conflicts? Note: because it is working at the moment I have a feeling Gradle might be applying the plugin anyway, but haven't dug too deep into it ever. |
Yes, if you resolve conflicts I'd be happy to take another look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's needed in all projects where there's a settings.gradle AND toolchains are used, which happens to be all 3.