test: add failing test for transitive runtime capability. #1456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autonomousapps
commented
May 20, 2025
Comment on lines
+63
to
+66
| // TODO(tsr): cleanup | ||
| // val isMainVisibleForDownstreamCompile = Bucket.isVisibleToTestCompileClasspath(mainUsages, mainDeclarations) | ||
| // val isMainVisibleForDownstreamRuntime = Bucket.isVisibleToTestRuntimeClasspath(mainUsages, mainDeclarations) | ||
| val visibility = Bucket.determineVisibility(mainUsages, mainDeclarations) |
autonomousapps
commented
May 20, 2025
| fun isDowngrade(): Boolean = (isRemove() || isCompileOnly() || isRuntimeOnly()) | ||
| fun isDowngrade(): Boolean = isRemove() || (!isAnyAdd() && (isCompileOnly() || isRuntimeOnly())) |
autonomousapps
commented
May 20, 2025
Comment on lines
+42
to
+43
| @PendingFeature | ||
| def "transitive dependencies with runtime capabilities are added directly (#gradleVersion)"() { |
There was a problem hiding this comment.
Getting this test to pass will be harder than originally expected. I've made a lot of assumptions about not providing "runtimeOnly" advice in the past.
…dardTransform. This simplifies construction of that class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.