Skip to content

fix: properly handle annotations (#1210) #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2025
Merged

fix: properly handle annotations (#1210) #1506

merged 1 commit into from
Aug 5, 2025

Conversation

Vampire
Copy link
Contributor

@Vampire Vampire commented Jul 31, 2025

Fixes #1210

@Vampire Vampire mentioned this pull request Jul 31, 2025
Closed
autonomousapps
autonomousapps reviewed Aug 2, 2025
View reviewed changes
Copy link
Owner

@autonomousapps autonomousapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks for the contribution.

Could you add a line to the changelog that summarizes this, including a brief explanation as to why we're doing this? This is a timely change, since my next release will be 3.0.0, and this is a breaking change.

...unctionalTest/groovy/com/autonomousapps/jvm/projects/AnnotationsImplementationProject.groovy
Comment on lines +129 to +130
// Deliberate in the same package as the consumer, to avoid import-based detection heuristics
package com.example.test;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this comment 👍

src/main/kotlin/com/autonomousapps/model/internal/intermediates/Reason.kt
Comment on lines -189 to -190
// TODO: ugh.
override val configurationName: String = "implementation, sometimes"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@Vampire Vampire requested a review from autonomousapps August 3, 2025 20:45
@autonomousapps autonomousapps merged commit d5b35cf into autonomousapps:main Aug 5, 2025
1 check passed
@Vampire Vampire deleted the issue-1210 branch August 6, 2025 15:05
@autonomousapps autonomousapps mentioned this pull request Aug 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autonomousapps autonomousapps autonomousapps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotations used to annotate and things (enum constants, class literals, ...) used for annotation member values should not count to ABI
2 participants
@Vampire @autonomousapps