Skip to content

Requests inside Tab implementation #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 50 commits into from
Aug 7, 2025
Merged

Requests inside Tab implementation #232

merged 50 commits into from
Aug 7, 2025

Conversation

thalissonvs
Copy link
Member

@thalissonvs thalissonvs commented Aug 6, 2025 •
edited
Loading

Closes #217
Closes #171

@thalissonvs
refactor: improve protocol types for network domain
cc48d2b
@thalissonvs
refactor: add TypedDict and Enum definitions for emulation and debugging
6ac5a4c
@thalissonvs
refactor: enhance browser command functionality with new methods and …
b32797c 
…types
@thalissonvs
refactor: refactor fetch command return types for better clarity and …
3bb8cc8 
…structure
@thalissonvs
refactor: refactor DOM event types and methods for better clarity and…
ad27400 
… structure
@thalissonvs
refactor: add new TypedDicts and enums for runtime event parameters
5980346
@thalissonvs
fix: remove unused event type aliases and clean up imports
65ebeae
@thalissonvs
refactor: remove legacy WindowBoundsDict for cleaner type definitions
792bef6
@thalissonvs
refactor: refactor AuthChallengeResponse and remove legacy definitions
7a1bd78
@thalissonvs
refactor: improve protocol types for input domain
cd47aaa
@thalissonvs
refactor: add IncludeWhitespace and RelationType enums to DOM types
f2bef1e
@thalissonvs
refactor: improve protocol types for page domain
e6ce8d3
@thalissonvs
refactor: refactor command response types for improved readability an…
e06a6ea 
…d consistency
@thalissonvs
refactor: improve protocol types for storage domain
b9b16b9
@thalissonvs
refactor: improve protocol types for target domain
877f7b7
@thalissonvs
refactor: refactor command responses to use EmptyResponse where appli…
d1dfb1c 
…cable
@thalissonvs
refactor: refactor command and event parameter types for better typing
1aea6fc
@thalissonvs
refactor: refactor DOM command types for improved code clarity and st…
3f0e5e5 
…ructure
@thalissonvs
refactor: refactor enums to inherit from str for better compatibility
816e1f7
@thalissonvs
fix: check for None in events_enabled before updating params
d31ef85
@thalissonvs
style: remove unnecessary comment from DomCommands class definition
451ef94
@thalissonvs
refactor: refactor fetch_commands to use updated type definitions
c2334c8
@thalissonvs
refactor: refactor input command methods to return specific command t…
a8442a3 
…ypes
@thalissonvs
refactor: refactor network commands to use specific command types
b6dd281
@thalissonvs
refactor: refactor page commands to use specific command types directly
47b3170
@thalissonvs
refactor: refactor command return types to specific command classes
ad36b01
@thalissonvs
refactor: refactor target command methods to use specific command types
39f5aa8
@thalissonvs
refactor: refactor storage command methods to return specific command…
928913e 
… types
@thalissonvs
refactor: refactor connection handler to use CDPEvent and typed commands
da967bd
@thalissonvs
refactor: refactor event handling to use specific event types for cla…
1c79271 
…rity
@thalissonvs
refactor: refactor type hints and improve command method signatures
2205d8d
@thalissonvs
feat: add Request handling and improve network log retrieval methods
e4749e6
@thalissonvs
feat: implement Request class for HTTP requests using fetch API
9e10a36
@thalissonvs
feat: add HTTP response object for browser-based fetch requests
a98d446
@thalissonvs
feat: add HTTP client functionality using the browser's fetch API
51279ff
@thalissonvs
refactor: refactor type hints in FindElementsMixin for clarity and ty…
6d4851a 
…pe safety
@thalissonvs
style: refactor function signatures for improved readability and style
abaad5b
@thalissonvs
refactor: refactor imports for cleaner organization and improved clarity
58a511f
@thalissonvs
refactor: add asynchronous function for makeRequest in JavaScript
ac19780
@thalissonvs
tests: add tests for new requests functionality
37710f9
@thalissonvs
build: ignore specific linting rules in Ruff configuration
7f2262b
@thalissonvs
style: refactor method signatures for improved readability and style
be02f73
@thalissonvs thalissonvs requested a review from LucasAlvws August 6, 2025 22:43
@thalissonvs thalissonvs self-assigned this Aug 6, 2025
@thalissonvs thalissonvs added the enhancement New feature or request label Aug 6, 2025
@codecov Codecov
Copy link

codecov bot commented Aug 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 99.76278% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pydoll/browser/requests/request.py 94.88% 9 Missing ⚠️
pydoll/browser/chromium/base.py 93.75% 1 Missing ⚠️
pydoll/browser/tab.py 95.83% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@thalissonvs thalissonvs linked an issue Aug 6, 2025 that may be closed by this pull request
[Feature Request]: Fetch-based request support inside Tab #171
Closed
2 tasks
@thalissonvs thalissonvs merged commit b16d5f8 into main Aug 7, 2025
21 checks passed
@thalissonvs thalissonvs deleted the feat/tab-request-api-issue-171 branch August 7, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasAlvws LucasAlvws Awaiting requested review from LucasAlvws

Assignees

@thalissonvs thalissonvs

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cleanup] Add PLR0913 and PLR0917 to ignored rules in Ruff config [Feature Request]: Fetch-based request support inside Tab
1 participant
@thalissonvs