Skip to content

Use bevy::light in examples instead of bevy::pbr::light re-export #20487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2025
Merged

Use bevy::light in examples instead of bevy::pbr::light re-export #20487

merged 1 commit into from
Aug 10, 2025

Conversation

atlv24
Copy link
Contributor

@atlv24 atlv24 commented Aug 10, 2025

Objective

  • Prepare for removing re-exports

Solution

  • title

Testing

  • cargo check --examples --all-features

@atlv24 atlv24 added A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 10, 2025
@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 10, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 10, 2025
Merged via the queue into bevyengine:main with commit ce416c3 Aug 10, 2025
41 checks passed
@atlv24 atlv24 deleted the ad/light-examples branch August 10, 2025 20:20
gwafotapa pushed a commit to gwafotapa/bevy that referenced this pull request Aug 12, 2025
@atlv24 @gwafotapa
Use bevy::light in examples instead of bevy::pbr::light re-export (be…
0e07cd2 
…vyengine#20487)

# Objective

- Prepare for removing re-exports

## Solution

- title

## Testing

- cargo check --examples --all-features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atlv24 @alice-i-cecile