Skip to content

Add bevy_shader prelude and move load_shader_library #20491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2025

Conversation

atlv24
Copy link
Contributor

@atlv24 atlv24 commented Aug 10, 2025

Objective

  • Prepare for removing re-exports
  • We want to use load_shader_library without bevy_render, so put it in bevy_shader

Solution

  • title

Testing

  • cargo check --examples --all-features

@atlv24 atlv24 added A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 10, 2025
@james7132 james7132 added this pull request to the merge queue Aug 10, 2025
Merged via the queue into bevyengine:main with commit b6cf514 Aug 10, 2025
37 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Aug 10, 2025
… solari, dev_tools instead of bevy_render::shader re-export (#20493)

# Objective

- Prepare for removing re-exports
- Probably depends on #20491 merging first

## Solution

- title

## Testing

- cargo check --examples --all-features

---------

Co-authored-by: Tim Blackbird <JustTheCoolDude@gmail.com>
github-merge-queue bot pushed a commit that referenced this pull request Aug 10, 2025
#20492)

# Objective

- Prepare for removing re-exports
- Probably depends on #20491 merging first

## Solution

- title

## Testing

- cargo check --examples --all-features
@atlv24 atlv24 deleted the ad/shader-prelude branch August 10, 2025 20:20
gwafotapa pushed a commit to gwafotapa/bevy that referenced this pull request Aug 12, 2025
# Objective

- Prepare for removing re-exports
- We want to use load_shader_library without bevy_render, so put it in
bevy_shader

## Solution

- title

## Testing

- cargo check --examples --all-features
gwafotapa pushed a commit to gwafotapa/bevy that referenced this pull request Aug 12, 2025
… solari, dev_tools instead of bevy_render::shader re-export (bevyengine#20493)

# Objective

- Prepare for removing re-exports
- Probably depends on bevyengine#20491 merging first

## Solution

- title

## Testing

- cargo check --examples --all-features

---------

Co-authored-by: Tim Blackbird <JustTheCoolDude@gmail.com>
gwafotapa pushed a commit to gwafotapa/bevy that referenced this pull request Aug 12, 2025
bevyengine#20492)

# Objective

- Prepare for removing re-exports
- Probably depends on bevyengine#20491 merging first

## Solution

- title

## Testing

- cargo check --examples --all-features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants