-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Docs for emissive color on StandardMaterial #20497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alice-i-cecile
wants to merge
4
commits into
bevyengine:main
Choose a base branch
from
alice-i-cecile:emissive-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atlv24
approved these changes
Aug 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
crates/bevy_pbr/src/pbr_material.rs
Outdated
/// From a physical perspective, the units of the emissive color | ||
/// are given in luminance (cd/m², aka nits), which is a measure of | ||
/// the amount of light emitted per unit area. | ||
/// | ||
/// Increasing the emissive strength of the color will impact visual effects | ||
/// like bloom, but it's important to note that **an emissive material won't | ||
/// light up surrounding areas like a light source**, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an emissive material won't light up surrounding areas like a light source
Unless you're using solari :P
atlv24
approved these changes
Aug 11, 2025
JMS55
reviewed
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Rendering
Drawing game state to the screen
C-Docs
An addition or correction to our documentation
D-Straightforward
Simple bug fixes and API improvements, docs, test and examples
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #18993.
Solution
I've done my best to synthesize and carefully word the discussion in the linked issue. That said, this is not my domain, so critique is very welcome.