-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Make bevy_ui not depend on bevy_render #20502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
991534f
to
103085e
Compare
103085e
to
e195b84
Compare
|
||
// TODO: replace Texture names with Image names? | ||
/// Adds the [`Image`] as an asset and makes sure that they are extracted and prepared for the GPU. | ||
pub struct ImagePlugin { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh why was this even in bevy_render T_T
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a step in the right direction, but why is this a dev-dep still?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the sampler stuff to image is really nice 👍.
Because testing needs to initialize ManualTextureViews for some reason, dunno. |
d0c8114
to
27d702b
Compare
6584891
to
0574a1d
Compare
Depends on #20506 |
It's just needed for the camera updates, I made a quick PR at #20512 that simplifies the UI test setup and removes the need for it. |
thanks for looking into that @ickshonpe ! i have been wondering if we want to move as much of camera_system's logic into bevy_camera as we can, and leave just a lil bit of it in bevy_render for resizing render target or whatever has to happen. Then we wouldnt need a test specific setup hopefully |
For layout bevy_ui is almost there already. All the window and camera queries are in |
Objective
Solution
Testing