local-remote-split-type-fix-auto-enter #2636

MagMueller · 2025-08-10T16:12:13Z

Auto-generated PR for branch: local-remote-split-type-fix-auto-enter

Summary by cubic

Migrated browser automation from Playwright to a pure Chrome DevTools Protocol (CDP) event-driven architecture, refactoring BrowserSession and related modules for improved reliability, extensibility, and testability.

New Architecture
- Replaced Playwright with direct CDP communication using an event bus and modular watchdogs for browser actions, DOM, downloads, security, and crash handling.
- Added new event models, refactored DOM extraction and serialization, and introduced enhanced DOM tree types.
- Updated tests, examples, and documentation to match the new event-driven system.

…to new-extraction-layer-magnus

…detection/download. mostly coded by claude-opus-4.1

…rowser-use into local-remote-split

…ltActionWatchdog

…Introduced methods for cleaning HTML, validating content relevance, and intelligently truncating long content. Enhanced markdown conversion and improved error handling for content extraction failures.

…TML to markdown conversion using markdownify, improved error handling, and streamlined memory management for extracted content. Removed obsolete methods related to HTML cleaning and content validation.

cursor · 2025-08-10T16:12:20Z

🚨 Bugbot Trial Expired

Your Bugbot trial has expired. Please purchase a license in the Cursor dashboard to continue using Bugbot.

tests/ci/test_action_NavigateToUrlEvent.py

+		assert len(browser_session.tabs) == initial_tabs_count + 1
+
+		# Verify focus switched to the new tab
+		assert 'example.com' in current_url


To fix the problem, we should parse the current_url using Python's urllib.parse module and check the hostname component directly, rather than using a substring check. Specifically, we should use urlparse(current_url).hostname and verify that it matches example.com or ends with .example.com (if subdomains are allowed). In this test, since the navigation is to 'https://example.com', a strict equality check is appropriate.

Steps:

Import urlparse from urllib.parse at the top of the file (if not already imported).

Replace the substring check ('example.com' in current_url) with a check on the parsed hostname: urlparse(current_url).hostname == 'example.com'.

cubic-dev-ai

cubic analysis

27 issues found across 90 files • Review in cubic

_{React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

cubic-dev-ai · 2025-08-10T16:19:16Z

tests/ci/test_action_ScrollEvent.py

+			params={'expression': 'window.pageYOffset', 'returnByValue': True},
+			session_id=cdp_session.session_id,
+		)
+		main_y = main_scroll.get('result', {}).get('value', 0)


The variable main_y is assigned but never used, which will raise an unused-variable warning in most linters and can block CI. Replace it with _ or remove the assignment to indicate the value is intentionally ignored. (Based on your team's feedback about keeping the codebase free of linter warnings.)

Prompt for AI agents

Address the following comment on tests/ci/test_action_ScrollEvent.py at line 379: <comment>The variable main_y is assigned but never used, which will raise an unused-variable warning in most linters and can block CI. Replace it with _ or remove the assignment to indicate the value is intentionally ignored. (Based on your team's feedback about keeping the codebase free of linter warnings.)</comment> <file context> @@ -0,0 +1,423 @@ +import asyncio + +import pytest +from pytest_httpserver import HTTPServer + +from browser_use.agent.views import ActionModel, ActionResult +from browser_use.browser import BrowserSession +from browser_use.browser.profile import BrowserProfile +from browser_use.controller.service import Controller </file context>

Suggested change

main_y = main_scroll.get('result', {}).get('value', 0)

_ = main_scroll.get('result', {}).get('value', 0)

cubic-dev-ai · 2025-08-10T16:19:16Z

tests/ci/test_security_watchdog.py

+	session = BrowserSession(browser_profile=profile)
+
+	# Track BrowserErrorEvents
+	error_events = []


The test collects BrowserErrorEvent instances but never asserts that the list remains empty, so the test will pass even when unexpected errors occur.

Prompt for AI agents

Address the following comment on tests/ci/test_security_watchdog.py at line 80: <comment>The test collects BrowserErrorEvent instances but never asserts that the list remains empty, so the test will pass even when unexpected errors occur.</comment> <file context> @@ -0,0 +1,155 @@ +"""Test navigation and security functionality.""" + +from typing import cast + +import pytest + +from browser_use.browser.events import ( + BrowserConnectedEvent, + BrowserErrorEvent, </file context>

cubic-dev-ai · 2025-08-10T16:19:17Z

browser_use/dom/views.py

+	cdp_timing: dict[str, float]
+
+
+@dataclass(slots=True)


Mutable dataclass defines a custom hash but is not frozen, so the hash can change after mutation, breaking dictionary/set invariants and leading to hard-to-trace bugs.

Prompt for AI agents

Address the following comment on browser_use/dom/views.py at line 52: <comment>Mutable dataclass defines a custom __hash__ but is not frozen, so the hash can change after mutation, breaking dictionary/set invariants and leading to hard-to-trace bugs.</comment> <file context> @@ -70,220 +31,467 @@ def __json__(self) -> dict: ] -@dataclass(frozen=False) -class DOMElementNode(DOMBaseNode): +@dataclass +class CurrentPageTargets: + page_session: TargetInfo + iframe_sessions: list[TargetInfo] </file context>

Suggested change

@dataclass(slots=True)

@dataclass(slots=True, frozen=True)

cubic-dev-ai · 2025-08-10T16:19:17Z

tests/ci/test_agent_shutdown.py

+async def test_no_leaked_asyncio_tasks():
+	"""Test that no asyncio tasks remain after agent shutdown."""
+	# Get initial tasks
+	initial_tasks = asyncio.all_tasks(asyncio.get_event_loop())


Calling asyncio.get_event_loop() inside a running coroutine is deprecated; use asyncio.get_running_loop() or omit the argument to all_tasks() instead.

Prompt for AI agents

Address the following comment on tests/ci/test_agent_shutdown.py at line 43: <comment>Calling asyncio.get_event_loop() inside a running coroutine is deprecated; use asyncio.get_running_loop() or omit the argument to all_tasks() instead.</comment> <file context> @@ -0,0 +1,163 @@ +"""Test agent shutdown and cleanup.""" + +import asyncio +import logging +import threading +import time + +from browser_use import Agent, BrowserProfile, BrowserSession +from tests.ci.conftest import create_mock_llm </file context>

cubic-dev-ai · 2025-08-10T16:19:17Z

browser_use/dom/playground/tree.py

+
+			await inject_highlighting_script(dom_service, serialized_dom_state.selector_map)
+
+			input('Done. Press Enter to continue...')


Calling the synchronous built-in input() inside an async loop blocks the event loop, defeating concurrency and potentially freezing other coroutines.

Prompt for AI agents

Address the following comment on browser_use/dom/playground/tree.py at line 124: <comment>Calling the synchronous built-in input() inside an async loop blocks the event loop, defeating concurrency and potentially freezing other coroutines.</comment> <file context> @@ -0,0 +1,128 @@ +import asyncio +import json +import time + +import aiofiles + +from browser_use.browser import BrowserProfile, BrowserSession +from browser_use.browser.types import ViewportSize +from browser_use.dom.debug.highlights import inject_highlighting_script, remove_highlighting_script </file context>

Suggested change

input('Done. Press Enter to continue...')

await asyncio.to_thread(input, 'Done. Press Enter to continue...')

cubic-dev-ai · 2025-08-10T16:19:19Z

examples/custom-functions/cua.py

-		page = await browser_session.get_current_page()
-		page_info = browser_session.browser_state_summary.page_info
+		# Get browser state summary
+		state = await browser_session.get_browser_state_summary()


page is now undefined due to removal of its assignment, causing a runtime NameError when handle_model_action(page, action) is called. (Based on your team's feedback about prioritizing critical runtime issues)

Prompt for AI agents

Address the following comment on examples/custom-functions/cua.py at line 134: <comment>`page` is now undefined due to removal of its assignment, causing a runtime NameError when `handle_model_action(page, action)` is called. (Based on your team's feedback about prioritizing critical runtime issues)</comment> <file context> @@ -130,14 +130,15 @@ async def openai_cua_fallback(params: OpenAICUAAction, browser_session: BrowserS print(f'🎯 CUA Action Starting - Goal: {params.description}') try: - page = await browser_session.get_current_page() - page_info = browser_session.browser_state_summary.page_info + # Get browser state summary + state = await browser_session.get_browser_state_summary() + page_info = state.page_info if not page_info: </file context>

cubic-dev-ai · 2025-08-10T16:19:19Z

tests/ci/test_watchdog.py

+
+
+@pytest.mark.asyncio
+async def test_watchdog_integration_with_session_lifecycle():


The first test is missing a try/finally tear-down; if an earlier assertion fails the browser session is left alive, leaking resources and jeopardising later tests.

Prompt for AI agents

Address the following comment on tests/ci/test_watchdog.py at line 21: <comment>The first test is missing a try/finally tear-down; if an earlier assertion fails the browser session is left alive, leaking resources and jeopardising later tests.</comment> <file context> @@ -0,0 +1,107 @@ +"""Test browser watchdog integration and lifecycle.""" + +from typing import cast + +import pytest + +from browser_use.browser.events import ( + BrowserConnectedEvent, + BrowserStartEvent, </file context>

cubic-dev-ai · 2025-08-10T16:19:19Z

examples/custom-functions/action_filters.py

+		)
+		url = result.get('result', {}).get('value', '')
+		return 'login' in url.lower() or 'signin' in url.lower()
+	except:


Bare except clause suppresses all exceptions and obscures underlying errors; catch a specific exception class instead or use "except Exception" with logging. (Based on your team's feedback about improving error handling and avoiding overly broad exception catching.)

Prompt for AI agents

Address the following comment on examples/custom-functions/action_filters.py at line 71: <comment>Bare except clause suppresses all exceptions and obscures underlying errors; catch a specific exception class instead or use "except Exception" with logging. (Based on your team's feedback about improving error handling and avoiding overly broad exception catching.)</comment> <file context> @@ -39,29 +38,58 @@ async def some_action(browser_session: BrowserSession): # Action will only be available to Agent on Google domains because of the domain filter @registry.action(description='Trigger disco mode', domains=['google.com', '*.google.com']) -async def disco_mode(page: Page): - await page.evaluate("""() => { - // define the wiggle animation - document.styleSheets[0].insertRule('@keyframes wiggle { 0% { transform: rotate(0deg); } 50% { transform: rotate(10deg); } 100% { transform: rotate(0deg); } }'); - - document.querySelectorAll("*").forEach(element => { </file context>

Suggested change

except:

except Exception:

cubic-dev-ai · 2025-08-10T16:19:19Z

browser_use/browser/events.py

+event_names = {
+	name.split('[')[0]
+	for name in globals().keys()
+	if not name.startswith('_') and issubclass(globals()[name], BaseEvent) and name != 'BaseEvent'


Calling issubclass() on non-class globals will raise TypeError and crash the module import; ensure the object is a type before invoking issubclass() (Based on your team's feedback about catching runtime errors early).

Prompt for AI agents

Address the following comment on browser_use/browser/events.py at line 372: <comment>Calling issubclass() on non-class globals will raise TypeError and crash the module import; ensure the object is a type before invoking issubclass() (Based on your team's feedback about catching runtime errors early).</comment> <file context> @@ -0,0 +1,380 @@ +"""Event definitions for browser communication.""" + +from typing import Any, Literal + +from bubus import BaseEvent +from bubus.models import T_EventResultType +from pydantic import Field, field_validator + +from browser_use.browser.views import BrowserStateSummary </file context>

cubic-dev-ai · 2025-08-10T16:19:19Z

examples/browser/window_sizing.py

-		# Navigate to a test page
-		await page.goto('https://example.com', wait_until='load')
+		# Navigate to a test page using events
+		nav_event = browser_session.event_bus.dispatch(NavigateToUrlEvent(url='https://example.com'))


Awaiting the dispatched NavigateToUrlEvent only waits for handlers to finish, but BrowserSession.on_NavigateToUrlEvent does not block until the requested page is fully loaded (it only sleeps 0.5 s). Subsequent size checks may run before navigation completes, leading to flaky example behaviour.

Prompt for AI agents

Address the following comment on examples/browser/window_sizing.py at line 65: <comment>Awaiting the dispatched NavigateToUrlEvent only waits for handlers to finish, but BrowserSession.on_NavigateToUrlEvent does not block until the requested page is fully loaded (it only sleeps 0.5 s). Subsequent size checks may run before navigation completes, leading to flaky example behaviour.</comment> <file context> @@ -40,17 +61,15 @@ async def example_custom_window_size(): ) await browser_session.start() - # Get the current page - page = await browser_session.get_current_page() - - # Navigate to a test page - await page.goto('https://example.com', wait_until='load') + # Navigate to a test page using events </file context>

…mote-split-type-fix-auto-enter

gregpr07 and others added 30 commits July 9, 2025 12:22

wip, started migrating to pure cdp

8a2eda1

wip, generated types for the dom tree

b6ba350

save huge models to slots -> HUGE speedup

73413ee

created serializers

1e57a8d

added snapshot information

b867019

wip, added serializer

900fdb6

added more snapshot data

ca71470

nicer types

779196d

started migration to pure cdp

7bf1706

fixed action param xpath test

d64913c

simple highlights

5cce5af

fixed out of viewport elements

bb253bf

fixed logic for new elements

fb5eec4

tiny refactor

66a52ab

vibe coded serializer

1a24cf2

added highllights natively

c3f0b8d

refactored to detect ALL elements

dd7586b

extraction, sage entire tree

65f94f7

Merge remote-tracking branch 'origin/eval/testing-new-cdp-ax-tree' in…

17d9f0e

…to new-extraction-layer-magnus

Basic extraction

a345dec

Basic editable properties

4ceb2eb

Improve debug script

1fa8e0d

Remove everything unaccesible for screenreaders

6a9e00b

Include timing

0de8497

Enter continue same state

ac607fa

New websites

01820f9

Highlights higher z index

3bc2175

Include non visable elements

36be62f

Move negative checks further up

f6e3fa1

Remove size 0 for svg to keep them interactive

3407e60

mertunsall and others added 8 commits August 10, 2025 00:21

update available file paths on pdf download and fix some bugs in pdf …

aef48b7

…detection/download. mostly coded by claude-opus-4.1

Merge branch 'local-remote-split' of https://github.com/browser-use/b…

4c0e20a

…rowser-use into local-remote-split

Merge branch 'local-remote-split-magnus' into local-remote-split

59425c0

Increase tag text from 25 to 100

9dc4f07

Add element focusability checks and improve focus strategies in Defau…

fcc737b

…ltActionWatchdog

Refactor HTML extraction and content processing in Controller class. …

70115c4

…Introduced methods for cleaning HTML, validating content relevance, and intelligently truncating long content. Enhanced markdown conversion and improved error handling for content extraction failures.

Auto enter

c6e7112

Refactor content extraction process in Controller class. Simplified H…

38d6836

…TML to markdown conversion using markdownify, improved error handling, and streamlined memory management for extracted content. Removed obsolete methods related to HTML cleaning and content validation.

mintlify bot deployed to staging - docs August 10, 2025 16:12 View deployment

MagMueller marked this pull request as draft August 10, 2025 16:12

github-advanced-security bot found potential problems Aug 10, 2025

View reviewed changes

cubic-dev-ai bot reviewed Aug 10, 2025

View reviewed changes

MagMueller and others added 17 commits August 10, 2025 10:25

Remove url blank from extract_structured_data

af8acb0

Wait for page in extract_structured_data

eb003f7

Only wait after first

5104f60

Never rebuild the dom in click

edb86c1

Add option to include screenshot in browser state summary retrieval

4a0ed1f

Check is visible

e0571b6

Include more info in state

88896c0

fixed dom PageInfo calculation

3aa7c18

Merge commit '3aa7c18faea15c3ab4a836fc9c37deb5c0045275' into local-re…

95cfdd5

…mote-split-type-fix-auto-enter

Simplified longer wait in browser state

9225769

Update empty DOM tree message to indicate potential loading delay

cb4d206

Fixed multiact cache

aa45460

Increase typing delay

fcf94bc

extract_structured_data descripiton for single use

2d63ccf

Fix remove highlights

97b565b

Fix extract content

39ff164

Replace empty links

ba81729

@@ -4,3 +4,3 @@
             from pytest_httpserver import HTTPServer
+            from urllib.parse import urlparse
             from browser_use.agent.views import ActionModel, ActionResult
@@ -398,3 +398,3 @@
             		# Verify focus switched to the new tab
-            		assert 'example.com' in current_url
+            		assert urlparse(current_url).hostname == 'example.com'
             		assert current_url != initial_url

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

local-remote-split-type-fix-auto-enter #2636

local-remote-split-type-fix-auto-enter #2636

MagMueller commented Aug 10, 2025 •

edited by cubic-dev-ai bot

Loading

Uh oh!

cursor bot commented Aug 10, 2025

Uh oh!

Check failure

Copilot Autofix

cubic-dev-ai bot left a comment

Uh oh!

cubic-dev-ai bot Aug 10, 2025

Uh oh!

cubic-dev-ai bot Aug 10, 2025

Uh oh!

cubic-dev-ai bot Aug 10, 2025

Uh oh!

cubic-dev-ai bot Aug 10, 2025

Uh oh!

cubic-dev-ai bot Aug 10, 2025

Uh oh!

cubic-dev-ai bot Aug 10, 2025

Uh oh!

cubic-dev-ai bot Aug 10, 2025

Uh oh!

cubic-dev-ai bot Aug 10, 2025

Uh oh!

cubic-dev-ai bot Aug 10, 2025

Uh oh!

cubic-dev-ai bot Aug 10, 2025

Uh oh!

Uh oh!

	main_y = main_scroll.get('result', {}).get('value', 0)
	_ = main_scroll.get('result', {}).get('value', 0)


		await inject_highlighting_script(dom_service, serialized_dom_state.selector_map)

		input('Done. Press Enter to continue...')

	input('Done. Press Enter to continue...')
	await asyncio.to_thread(input, 'Done. Press Enter to continue...')



		@pytest.mark.asyncio
		async def test_watchdog_integration_with_session_lifecycle():

local-remote-split-type-fix-auto-enter #2636

Are you sure you want to change the base?

local-remote-split-type-fix-auto-enter #2636

Conversation

MagMueller commented Aug 10, 2025 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Uh oh!

cursor bot commented Aug 10, 2025

🚨 Bugbot Trial Expired

Uh oh!

Check failure

Uh oh!

Copilot Autofix

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

cubic analysis

Uh oh!

cubic-dev-ai bot Aug 10, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Aug 10, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Aug 10, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Aug 10, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Aug 10, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Aug 10, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Aug 10, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Aug 10, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Aug 10, 2025

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Aug 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MagMueller commented Aug 10, 2025 •

edited by cubic-dev-ai bot

Loading