perf: reduce schema sync operations from 3 to 2 during migration #17101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we performed 3 separate schema sync operations during each migration: 1. Pre-migration: SyncDatabaseSchemaToHistory() - creates history snapshot 2. Post-migration: SyncDatabaseSchemaToHistory() - creates history snapshot 3. Final: SyncDatabaseSchema() - updates live metadata This commit optimizes the process to only 2 sync operations: 1. Pre-migration: SyncDatabaseSchemaToHistory() - creates history snapshot 2. Post-migration: Combined sync that creates history AND updates metadata Changes: - Refactored syncer.go to expose doSyncDatabaseSchema() as the core implementation - Updated endMigration() to always perform schema sync (with or without history) - Removed redundant sync calls from all executor implementations - Cleaned up unused imports This reduces database operations by 33% during migrations while maintaining all functionality for audit trails, rollback capabilities, and metadata accuracy. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
rebelice
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
During each schema migration, we were performing 3 separate database sync operations:
This was inefficient as operations 2 and 3 could be combined.
Solution
Refactored the sync process to combine the post-migration history creation with metadata update:
Changes Made
doSyncDatabaseSchema()to avoid naming conflictsendMigration()to always perform schema sync (with or without history)endMigration()Performance Impact
Test Plan
🤖 Generated with Claude Code