packages/platform/examples/base/tests/create-event-type-atom/create-event-type.e2e.ts (1)

12-14: Consider extracting test data for better maintainability.

The hardcoded test values make the test less maintainable and could cause conflicts if multiple tests run concurrently.

Extract test data to constants:

+const TEST_DATA = {
+  eventName: `e2e event ${Date.now()}`,
+  description: 'This is an e2e test event description'
+};
+
 test('create event type using CreateEventTypeAtom', async ({ page }) => {
   await page.goto('/');
   await page.goto('/event-types');
   await expect(page).toHaveURL('/event-types');
   await expect(page.locator('body')).toBeVisible();
-  await page.fill('[data-testid="event-type-quick-chat"]', 'e2e event');
-  await page.fill('textarea[placeholder="A quick video meeting."]', 'This is an e2e test event description');
+  await page.fill('[data-testid="event-type-quick-chat"]', TEST_DATA.eventName);
+  await page.fill('textarea[placeholder="A quick video meeting."]', TEST_DATA.description);

This approach reduces test flakiness and improves maintainability.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: CR
PR: calcom/cal.com#0
File: .cursor/rules/review.mdc:0-0
Timestamp: 2025-07-28T11:50:23.946Z
Learning: For large pull requests (>500 lines changed or >10 files touched), advise splitting into smaller, focused PRs by feature, layer, dependency chain, or file/module

Learnt from: vijayraghav-io
PR: calcom/cal.com#21072
File: .env.example:354-357
Timestamp: 2025-07-18T08:49:18.779Z
Learning: For E2E integration tests that require real third-party service credentials (like Outlook calendar), it's acceptable to temporarily include actual test account credentials in .env.example during feature development and validation, provided there's a clear plan to replace them with placeholder values before final release. Test credentials should be for dedicated test tenants/accounts, not production systems.

Learnt from: CR
PR: calcom/cal.com#0
File: .cursor/rules/review.mdc:0-0
Timestamp: 2025-07-28T11:50:23.946Z
Learning: Applies to **/*.{service,repository}.ts : Avoid dot-suffixes like `.service.ts` or `.repository.ts` for new files; reserve `.test.ts`, `.spec.ts`, `.types.ts` for their specific purposes

packages/platform/atoms/README.md (2)

39-40: Convert bare URL into proper Markdown link to satisfy MD034

markdownlint flagged the newly-added bare URL. Using inline link syntax is more maintainable and avoids the linter warning.

-- https://docs.gitlab.com/development/changelog/
+- [GitLab changelog guidelines](https://docs.gitlab.com/development/changelog/)

---

45-52: Add language identifier to fenced block (MD040)

The .env snippet lacks a language tag, triggering MD040. Annotate the block as env (or bash) so editors get syntax highlighting and linter noise is removed.

-```
+```env
 NEXT_PUBLIC_X_CAL_ID=""
 X_CAL_SECRET_KEY=""
 NEXT_PUBLIC_CALCOM_API_URL="https://api.cal.com/v2"
 VITE_BOOKER_EMBED_OAUTH_CLIENT_ID=""
 VITE_BOOKER_EMBED_API_URL="https://api.cal.com/v2"
 ORGANIZATION_ID=""

</blockquote></details>

</blockquote></details>

<details>
<summary>📜 Review details</summary>

**Configuration used: CodeRabbit UI**
**Review profile: CHILL**
**Plan: Pro**


<details>
<summary>📥 Commits</summary>

Reviewing files that changed from the base of the PR and between d1d7b8d4ffc218c4895973c7edf5ad28732da35c and 50b03aceec2f01aa24dedacbd0b1ba1d63edd155.

</details>

<details>
<summary>📒 Files selected for processing (1)</summary>

* `packages/platform/atoms/README.md` (1 hunks)

</details>

<details>
<summary>🧰 Additional context used</summary>

<details>
<summary>🧠 Learnings (1)</summary>

<details>
<summary>📓 Common learnings</summary>

Learnt from: CR
PR: calcom/cal.com#0
File: .cursor/rules/review.mdc:0-0
Timestamp: 2025-07-28T11:50:23.946Z
Learning: For large pull requests (>500 lines changed or >10 files touched), advise splitting into smaller, focused PRs by feature, layer, dependency chain, or file/module

Learnt from: vijayraghav-io
PR: #21072
File: .env.example:354-357
Timestamp: 2025-07-18T08:49:18.779Z
Learning: For E2E integration tests that require real third-party service credentials (like Outlook calendar), it's acceptable to temporarily include actual test account credentials in .env.example during feature development and validation, provided there's a clear plan to replace them with placeholder values before final release. Test credentials should be for dedicated test tenants/accounts, not production systems.

</details>

</details><details>
<summary>🪛 markdownlint-cli2 (0.17.2)</summary>

<details>
<summary>packages/platform/atoms/README.md</summary>

39-39: Bare URL used

(MD034, no-bare-urls)

---

45-45: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

</details>

</details>

</details>

<details>
<summary>⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)</summary>

* GitHub Check: Install dependencies / Yarn install & cache
* GitHub Check: Atoms E2E Tests

</details>

<details>
<summary>🔇 Additional comments (1)</summary><blockquote>

<details>
<summary>packages/platform/atoms/README.md (1)</summary>

`43-43`: **Verify script name `yarn dev-on`**

Most workspaces use a `dev` or `dev:watch` script; `dev-on` is uncommon. Please confirm the script exists in `packages/platform/atoms/package.json`. If it’s actually `dev`, update the instruction to avoid confusion.

</details>

</blockquote></details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

.github/workflows/atoms-e2e.yml (1)

30-30: Runner label is still non-standard – please replace or ensure self-hosted config
The workflow continues to use buildjet-4vcpu-ubuntu-2204, which GitHub does not recognise as a hosted runner. Unless you have a correctly configured self-hosted runner with that exact label, jobs will queue forever. Switch to an official label such as ubuntu-22.04 / ubuntu-latest-4-cores, or document the self-hosted runner setup.

.github/workflows/atoms-e2e.yml (1)

26-29: Add a concurrency group to avoid stacking CI minutes on multiple PR pushes
When contributors force-push frequently, earlier jobs keep running unnecessarily. Define a concurrency key so that only the latest commit per PR executes:

concurrency:
  group: atoms-e2e-${{ github.head_ref }}
  cancel-in-progress: true

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: CR
PR: calcom/cal.com#0
File: .cursor/rules/review.mdc:0-0
Timestamp: 2025-07-28T11:50:23.946Z
Learning: For large pull requests (>500 lines changed or >10 files touched), advise splitting into smaller, focused PRs by feature, layer, dependency chain, or file/module

Learnt from: vijayraghav-io
PR: calcom/cal.com#21072
File: .env.example:354-357
Timestamp: 2025-07-18T08:49:18.779Z
Learning: For E2E integration tests that require real third-party service credentials (like Outlook calendar), it's acceptable to temporarily include actual test account credentials in .env.example during feature development and validation, provided there's a clear plan to replace them with placeholder values before final release. Test credentials should be for dedicated test tenants/accounts, not production systems.

.github/workflows/atoms-e2e.yml (2)

31-31: Non-standard runner label still unresolved

The workflow still uses the unknown label buildjet-4vcpu-ubuntu-2204. GitHub-hosted machines won’t recognise it, so the job will never start unless a self-hosted runner with that exact label is registered. Replace it with an official label (e.g. ubuntu-22.04 or ubuntu-latest-4-cores) or document the custom runner in actionlint.yaml.

-    runs-on: buildjet-4vcpu-ubuntu-2204
+    runs-on: ubuntu-latest-4-cores

---

50-52: Artifact paths will be empty because they’re resolved from the repo root

actions/upload-artifact resolves path from $GITHUB_WORKSPACE, not from the preceding working-directory (packages/platform/examples/base). The current values will upload empty artefacts. Prefix the correct sub-directory:

-          path: test-results
+          path: packages/platform/examples/base/test-results
@@
-          path: playwright-report
+          path: packages/platform/examples/base/playwright-report

Also applies to: 57-58

.github/workflows/atoms-e2e.yml (1)

17-26: Secrets not available to forked PRs – expect CI failures

The job is triggered by pull_request, which includes forks, but relies on numerous repository secrets (ATOMS_E2E_OAUTH_CLIENT_ID, Docker creds, database URLs, etc.). These secrets are not exposed to untrusted forks, so the job will error out for external contributors.

Consider one of:

1. Use pull_request_target (with great care for security),
2. Run the workflow only on push to protected branches, or
3. Guard secret-dependent steps with if: env.ATOMS_E2E_OAUTH_CLIENT_ID != ''.

Failing to address this will produce red CI for all community PRs.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: CR
PR: calcom/cal.com#0
File: .cursor/rules/review.mdc:0-0
Timestamp: 2025-07-28T11:50:23.946Z
Learning: For large pull requests (>500 lines changed or >10 files touched), advise splitting into smaller, focused PRs by feature, layer, dependency chain, or file/module

Learnt from: vijayraghav-io
PR: calcom/cal.com#21072
File: .env.example:354-357
Timestamp: 2025-07-18T08:49:18.779Z
Learning: For E2E integration tests that require real third-party service credentials (like Outlook calendar), it's acceptable to temporarily include actual test account credentials in .env.example during feature development and validation, provided there's a clear plan to replace them with placeholder values before final release. Test credentials should be for dedicated test tenants/accounts, not production systems.

.github/workflows/atoms-e2e.yml (2)

44-50: Artifact upload will fail—test-results path is wrong
actions/upload-artifact@v4 resolves path from the repository root, not the working-directory used in the previous run step. The Playwrightrun happens inside packages/platform/examples/base, so the folder ends up at packages/platform/examples/base/test-results.
If the path isn’t fixed, the step will throw “no files found” and fail the entire job (v4 is strict).

-          path: test-results
+          path: packages/platform/examples/base/test-results

---

51-56: Same issue for Playwright report directory
The upload step points to a non-existent root-level directory; update it to the correct relative path.

-          path: playwright-report
+          path: packages/platform/examples/base/playwright-report

.github/workflows/atoms-e2e.yml (1)

13-15: Over-broad permissions—consider dropping actions: write
Unless this job intentionally creates/updates workflow runs or artifacts via the GitHub API, actions: write isn’t required. Reducing to the minimum (often contents: read, statuses: write) follows the principle of least privilege and limits blast radius if a token leaks.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: CR
PR: calcom/cal.com#0
File: .cursor/rules/review.mdc:0-0
Timestamp: 2025-07-28T11:50:23.946Z
Learning: For large pull requests (>500 lines changed or >10 files touched), advise splitting into smaller, focused PRs by feature, layer, dependency chain, or file/module

Learnt from: vijayraghav-io
PR: calcom/cal.com#21072
File: .env.example:354-357
Timestamp: 2025-07-18T08:49:18.779Z
Learning: For E2E integration tests that require real third-party service credentials (like Outlook calendar), it's acceptable to temporarily include actual test account credentials in .env.example during feature development and validation, provided there's a clear plan to replace them with placeholder values before final release. Test credentials should be for dedicated test tenants/accounts, not production systems.

Learnt from: supalarry
PR: calcom/cal.com#22926
File: .github/workflows/atoms-e2e.yml:31-31
Timestamp: 2025-08-07T08:53:45.434Z
Learning: Cal.com uses BuildJet runners extensively in their GitHub Actions workflows, including `buildjet-4vcpu-ubuntu-2204` and `buildjet-2vcpu-ubuntu-2204`. These are valid custom runners for their organization and should not be flagged as issues.

Learnt from: CR
PR: calcom/cal.com#0
File: .cursor/rules/review.mdc:0-0
Timestamp: 2025-07-28T11:50:23.946Z
Learning: For large pull requests (>500 lines changed or >10 files touched), advise splitting into smaller, focused PRs by feature, layer, dependency chain, or file/module

.github/workflows/atoms-e2e.yml (1)

44-56: Artifact paths still incorrect when working-directory is set

Previous feedback noted that actions/upload-artifact resolves path from the workspace root, not from the step’s working-directory.
Because tests run inside packages/platform/examples/base, the generated folders live under that directory. As written, the uploads will be empty.

-          path: test-results
+          path: packages/platform/examples/base/test-results
@@
-          path: playwright-report
+          path: packages/platform/examples/base/playwright-report

.github/workflows/atoms-e2e.yml (1)

31-41: Pin an explicit Node version for deterministic CI runs

The job installs Node implicitly via custom Yarn/Playwright actions. Explicitly setting a Node version (e.g. with actions/setup-node@v4) improves reproducibility across contributors and runners, and prevents silent breakage when the default runner version changes.

Example insertion before dependency steps:

      - uses: actions/setup-node@v4
        with:
          node-version: '20'
          cache: 'yarn'

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: CR
PR: calcom/cal.com#0
File: .cursor/rules/review.mdc:0-0
Timestamp: 2025-07-28T11:50:23.946Z
Learning: For large pull requests (>500 lines changed or >10 files touched), advise splitting into smaller, focused PRs by feature, layer, dependency chain, or file/module

Learnt from: vijayraghav-io
PR: calcom/cal.com#21072
File: .env.example:354-357
Timestamp: 2025-07-18T08:49:18.779Z
Learning: For E2E integration tests that require real third-party service credentials (like Outlook calendar), it's acceptable to temporarily include actual test account credentials in .env.example during feature development and validation, provided there's a clear plan to replace them with placeholder values before final release. Test credentials should be for dedicated test tenants/accounts, not production systems.

Learnt from: supalarry
PR: calcom/cal.com#22926
File: .github/workflows/atoms-e2e.yml:31-31
Timestamp: 2025-08-07T08:53:45.434Z
Learning: Cal.com uses BuildJet runners extensively in their GitHub Actions workflows, including `buildjet-4vcpu-ubuntu-2204` and `buildjet-2vcpu-ubuntu-2204`. These are valid custom runners for their organization and should not be flagged as issues.

Learnt from: CR
PR: calcom/cal.com#0
File: .cursor/rules/review.mdc:0-0
Timestamp: 2025-07-28T11:50:23.946Z
Learning: For large pull requests (>500 lines changed or >10 files touched), advise splitting into smaller, focused PRs by feature, layer, dependency chain, or file/module

.github/workflows/atoms-e2e.yml (2)

31-31: BuildJet runner label is OK for this org.

Cal.com uses BuildJet runners across workflows; keep as-is. Consider adding your custom labels to actionlint config to silence the false-positive.

---

45-57: Fix artifact upload paths (current paths will upload nothing).

upload-artifact resolves paths from the workspace root, not the previous step’s working-directory. Prefix with the package path to capture the actual folders.

       - name: Upload Test Results
         uses: actions/upload-artifact@v4
         if: always()
         with:
           name: atoms-e2e-test-results
-          path: test-results
+          path: packages/platform/examples/base/test-results
           retention-days: 7
       - name: Upload Playwright Report
         uses: actions/upload-artifact@v4
         if: always()
         with:
           name: atoms-e2e-playwright-report
-          path: playwright-report
+          path: packages/platform/examples/base/playwright-report
           retention-days: 7

.github/workflows/atoms-e2e.yml (2)

13-16: Tighten permissions (actions: write likely unnecessary).

Upload-artifact and checkout don’t require actions: write. Prefer least privilege.

 permissions:
-  actions: write
   contents: read

---

29-30: Optional: increase timeout or add concurrency to avoid burning runners.

If E2E occasionally runs long, bump to 25–30 min. Also consider concurrency to cancel superseded runs.

Example:

   atoms-e2e:
-    timeout-minutes: 15
+    timeout-minutes: 25
+    concurrency:
+      group: atoms-e2e-${{ github.ref }}
+      cancel-in-progress: true

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: supalarry
PR: calcom/cal.com#22926
File: .github/workflows/atoms-e2e.yml:31-31
Timestamp: 2025-08-07T08:53:45.434Z
Learning: Cal.com uses BuildJet runners extensively in their GitHub Actions workflows, including `buildjet-4vcpu-ubuntu-2204` and `buildjet-2vcpu-ubuntu-2204`. These are valid custom runners for their organization and should not be flagged as issues.