-
Notifications
You must be signed in to change notification settings - Fork 371
Added missing ptBR translations #6503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 416efa8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@fell-lucas is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThis update introduces a new changeset file documenting a patch release for the Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
🔭 Outside diff range comments (1)
packages/localizations/src/pt-BR.ts (1)
1058-1058
: Untranslated string: “Add” should be localizedThis is visible UI text; translate to pt-BR.
- formButtonPrimary__add: 'Add', + formButtonPrimary__add: 'Adicionar',
🧹 Nitpick comments (2)
packages/localizations/src/pt-BR.ts (1)
1-1286
: Tests and lintingNo tests were added. Consider adding a key-coverage and placeholder-parity test (like the script above) to prevent regressions. Also ensure Prettier/ESLint pass for this file.
You can adapt the script above into a unit test to enforce parity with en-US.
.changeset/forty-bottles-accept.md (1)
1-6
: Changeset looks correct; minor copy nitConsider using hyphenated locale and imperative mood.
-added missing ptBR translations +add missing pt-BR translations
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.changeset/forty-bottles-accept.md
(1 hunks)packages/localizations/src/pt-BR.ts
(17 hunks)
🧰 Additional context used
📓 Path-based instructions (10)
.changeset/**
📄 CodeRabbit Inference Engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
.changeset/forty-bottles-accept.md
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
**/*.{js,jsx,ts,tsx}
: All code must pass ESLint checks with the project's configuration
Follow established naming conventions (PascalCase for components, camelCase for variables)
Maintain comprehensive JSDoc comments for public APIs
Use dynamic imports for optional features
All public APIs must be documented with JSDoc
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Profile and optimize critical paths
Validate all inputs and sanitize outputs
Implement proper logging with different levels
Files:
packages/localizations/src/pt-BR.ts
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
packages/localizations/src/pt-BR.ts
packages/**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
TypeScript is required for all packages
Files:
packages/localizations/src/pt-BR.ts
packages/**/*.{ts,tsx,d.ts}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Packages should export TypeScript types alongside runtime code
Files:
packages/localizations/src/pt-BR.ts
**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (.cursor/rules/development.mdc)
Use proper TypeScript error types
**/*.{ts,tsx}
: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoidany
type - preferunknown
when type is uncertain, then narrow with type guards
Useinterface
for object shapes that might be extended
Usetype
for unions, primitives, and computed types
Preferreadonly
properties for immutable data structures
Useprivate
for internal implementation details
Useprotected
for inheritance hierarchies
Usepublic
explicitly for clarity in public APIs
Preferreadonly
for properties that shouldn't change after construction
Prefer composition and interfaces over deep inheritance chains
Use mixins for shared behavior across unrelated classes
Implement dependency injection for loose coupling
Let TypeScript infer when types are obvious
Useconst assertions
for literal types:as const
Usesatisfies
operator for type checking without widening
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Use type-only imports:import type { ... } from ...
Noany
types without justification
Proper error handling with typed errors
Consistent use ofreadonly
for immutable data
Proper generic constraints
No unused type parameters
Proper use of utility types instead of manual type construction
Type-only imports where possible
Proper tree-shaking friendly exports
No circular dependencies
Efficient type computations (avoid deep recursion)
Files:
packages/localizations/src/pt-BR.ts
packages/localizations/**/*
📄 CodeRabbit Inference Engine (.cursor/rules/monorepo.mdc)
Localization files must be placed in 'packages/localizations/'.
Files:
packages/localizations/src/pt-BR.ts
**/*.{js,ts,tsx,jsx}
📄 CodeRabbit Inference Engine (.cursor/rules/monorepo.mdc)
Support multiple Clerk environment variables (CLERK_, NEXT_PUBLIC_CLERK_, etc.) for configuration.
Files:
packages/localizations/src/pt-BR.ts
**/*
⚙️ CodeRabbit Configuration File
If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes.
Files:
packages/localizations/src/pt-BR.ts
**/localizations/**/*.ts
⚙️ CodeRabbit Configuration File
**/localizations/**/*.ts
: Review the changes to localization files with the following guidelines:
- Ensure that no existing translations are accidentally removed unless they are being replaced or fixed. If a string is removed, verify that it is intentional and justified.
- Check that all translations are friendly, formal, or semi-formal. Explicit, offensive, or inappropriate language is not allowed. If you find any potentially offensive language or are unsure, tag the @clerk/sdk-infra team in a separate comment. If you do not intend to tag the team, refer to it as "Clerk SDK Infra team" instead.
- Use the most up-to-date base localization file (https://github.com/clerk/javascript/blob/main/packages/localizations/src/en-US.ts) to validate changes, ensuring consistency and completeness.
- Confirm that new translations are accurate, contextually appropriate, and match the intent of the original English strings.
- Check for formatting issues, such as missing placeholders, incorrect variable usage, or syntax errors.
- Ensure that all keys are unique and that there are no duplicate or conflicting entries.
- If you notice missing translations for new keys, flag them for completion.
Files:
packages/localizations/src/pt-BR.ts
🔇 Additional comments (6)
packages/localizations/src/pt-BR.ts (6)
17-36
: New organization chooser translations read wellWording is clear and semi-formal; placeholders look correct. No issues found.
281-283
: API Keys titles/nav look consistentThe additions for API Keys in org and user sections are consistent and clear. No issues found.
Also applies to: 403-409, 931-933, 1116-1122
721-723
: Sign-in combined subtitle is friendly and appropriateTone and phrasing look good for pt-BR. No issues found.
822-823
: Social provider label (many-in-view) looks correctShowing only the provider name matches expected pattern. No issues found.
829-845
: Error messages look accurate and safeWording is clear, formal, and non-offensive. Placeholders appear correct.
Also applies to: 861-862, 882-883
1-1286
: Confirm translation key and placeholder parity
I attempted to run the comparison script, but it didn’t emit any results. Please manually verify that:
- pt-BR covers every key defined in en-US (no missing or extra entries)
- Each {{…}} placeholder in pt-BR exactly matches its counterpart in en-US (no missing or stray variables)
lastUsed__days: '{{days}}d atrás', | ||
lastUsed__hours: '{{hours}}h atrás', | ||
lastUsed__minutes: '{{minutes}}m atrás', | ||
lastUsed__months: '{{months}}m atrás', | ||
lastUsed__seconds: '{{seconds}}s atrás', | ||
lastUsed__years: '{{years}}a atrás', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Disambiguate time abbreviations for minutes vs. months
Both minutes and months use “m”, which is ambiguous. Suggest:
- minutes → “min”
- months → “mês(es)”
This matches common pt-BR conventions and avoids confusion.
- lastUsed__minutes: '{{minutes}}m atrás',
- lastUsed__months: '{{months}}m atrás',
+ lastUsed__minutes: '{{minutes}}min atrás',
+ lastUsed__months: '{{months}}mês(es) atrás',
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
lastUsed__days: '{{days}}d atrás', | |
lastUsed__hours: '{{hours}}h atrás', | |
lastUsed__minutes: '{{minutes}}m atrás', | |
lastUsed__months: '{{months}}m atrás', | |
lastUsed__seconds: '{{seconds}}s atrás', | |
lastUsed__years: '{{years}}a atrás', | |
lastUsed__days: '{{days}}d atrás', | |
lastUsed__hours: '{{hours}}h atrás', | |
- lastUsed__minutes: '{{minutes}}m atrás', | |
- lastUsed__months: '{{months}}m atrás', | |
+ lastUsed__minutes: '{{minutes}}min atrás', | |
+ lastUsed__months: '{{months}}mês(es) atrás', | |
lastUsed__seconds: '{{seconds}}s atrás', | |
lastUsed__years: '{{years}}a atrás', |
🤖 Prompt for AI Agents
In packages/localizations/src/pt-BR.ts between lines 57 and 62, the time
abbreviations for minutes and months both use "m", causing ambiguity. Change the
abbreviation for minutes from "m" to "min" and for months from "m" to "mês" or
"meses" to clearly distinguish them according to pt-BR conventions.
confirmationText: 'Revogar', | ||
formButtonPrimary__revoke: 'Revogar chave', | ||
formHint: 'Tem certeza de que deseja excluir esta chave secreta?', | ||
formTitle: 'Revogar chave secreta "{{apiKeyName}}"?', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consistent terminology: use “chave de API” (not “chave secreta”)
Elsewhere you use “Chaves de API”. For consistency and clarity, prefer “chave de API” in revoke copy and title.
- formHint: 'Tem certeza de que deseja excluir esta chave secreta?',
- formTitle: 'Revogar chave secreta "{{apiKeyName}}"?',
+ formHint: 'Tem certeza de que deseja excluir esta chave de API?',
+ formTitle: 'Revogar chave de API "{{apiKeyName}}"?',
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
confirmationText: 'Revogar', | |
formButtonPrimary__revoke: 'Revogar chave', | |
formHint: 'Tem certeza de que deseja excluir esta chave secreta?', | |
formTitle: 'Revogar chave secreta "{{apiKeyName}}"?', | |
}, | |
confirmationText: 'Revogar', | |
formButtonPrimary__revoke: 'Revogar chave', | |
formHint: 'Tem certeza de que deseja excluir esta chave de API?', | |
formTitle: 'Revogar chave de API "{{apiKeyName}}"?', | |
}, |
🤖 Prompt for AI Agents
In packages/localizations/src/pt-BR.ts around lines 65 to 69, replace all
instances of "chave secreta" with "chave de API" in the revoke confirmation text
and title to maintain consistent terminology across the application. Update the
formHint and formTitle strings accordingly to use "chave de API" instead of
"chave secreta".
formFieldInputPlaceholder__apiKeyName: undefined, | ||
formFieldInputPlaceholder__apiKeyDescription: 'Explique por que você está gerando esta chave', | ||
formFieldInputPlaceholder__apiKeyExpirationDate: 'Selecionar data', | ||
formFieldInputPlaceholder__apiKeyName: 'Digite o nome da sua chave secreta', | ||
formFieldInputPlaceholder__backupCode: 'Insira o código de backup', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Placeholder: prefer “chave de API” over “chave secreta”
Align with the rest of the file (e.g., page titles) and common wording.
- formFieldInputPlaceholder__apiKeyName: 'Digite o nome da sua chave secreta',
+ formFieldInputPlaceholder__apiKeyName: 'Digite o nome da sua chave de API',
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In packages/localizations/src/pt-BR.ts at line 219, the placeholder text uses
"código de backup" which should be updated to use "chave de API" to align with
the rest of the file and common terminology. Replace the string value with
"Insira a chave de API" to maintain consistency in wording.
formFieldLabel__apiKeyDescription: 'Descrição', | ||
formFieldLabel__apiKeyExpiration: 'Expiração', | ||
formFieldLabel__apiKeyName: 'Nome da chave secreta', | ||
formFieldLabel__automaticInvitations: 'Ativar convites automáticos para este domínio', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Label: prefer “chave de API” over “chave secreta”
Keep terminology consistent with titles/navigation.
- formFieldLabel__apiKeyName: 'Nome da chave secreta',
+ formFieldLabel__apiKeyName: 'Nome da chave de API',
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
formFieldLabel__apiKeyDescription: 'Descrição', | |
formFieldLabel__apiKeyExpiration: 'Expiração', | |
formFieldLabel__apiKeyName: 'Nome da chave secreta', | |
formFieldLabel__automaticInvitations: 'Ativar convites automáticos para este domínio', | |
formFieldLabel__apiKeyDescription: 'Descrição', | |
formFieldLabel__apiKeyExpiration: 'Expiração', | |
formFieldLabel__apiKeyName: 'Nome da chave de API', | |
formFieldLabel__automaticInvitations: 'Ativar convites automáticos para este domínio', |
🤖 Prompt for AI Agents
In packages/localizations/src/pt-BR.ts around lines 233 to 236, the label "Nome
da chave secreta" should be changed to "Nome da chave de API" to maintain
consistent terminology with titles and navigation. Update the string value
accordingly to reflect this preferred phrasing.
destructiveAction: 'Remover carteira', | ||
detailsAction__nonPrimary: undefined, | ||
detailsAction__nonPrimary: 'Conectar carteira', | ||
primaryButton: 'Carteiras Web3', | ||
title: 'Carteiras Web3', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely wrong action label: should be “Definir como principal”
For consistency with similar actions (e.g., phoneCode.detailsAction__nonPrimary), this should set the wallet as primary, not “connect wallet”.
- detailsAction__nonPrimary: 'Conectar carteira',
+ detailsAction__nonPrimary: 'Definir como principal',
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
destructiveAction: 'Remover carteira', | |
detailsAction__nonPrimary: undefined, | |
detailsAction__nonPrimary: 'Conectar carteira', | |
primaryButton: 'Carteiras Web3', | |
title: 'Carteiras Web3', | |
}, | |
destructiveAction: 'Remover carteira', | |
- detailsAction__nonPrimary: 'Conectar carteira', | |
+ detailsAction__nonPrimary: 'Definir como principal', | |
primaryButton: 'Carteiras Web3', | |
title: 'Carteiras Web3', |
🤖 Prompt for AI Agents
In packages/localizations/src/pt-BR.ts around lines 1247 to 1251, the label for
detailsAction__nonPrimary is incorrectly set to "Conectar carteira" but should
be "Definir como principal" to match the intended action of setting the wallet
as primary. Update the string value of detailsAction__nonPrimary to "Definir
como principal" for consistency with similar action labels.
Description
Adds missing ptBR translations that are available in the enUS translation file.
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change
Summary by CodeRabbit