feat(layers): Graph and Paper embedding layers implementation #2908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumilingus
reviewed
Jul 11, 2025
| @@ -70,6 +71,17 @@ export const Graph = Model.extend({ | |||
|
|
|||
| opt = opt || {}; | |||
|
|
|||
| this.enableCellLayers = opt.enableCellLayers || false; | |||
|
|
|||
| this.defaultLayerName = 'cells'; | |||
There was a problem hiding this comment.
we should move this outside as class property
kumilingus
reviewed
Jul 11, 2025
| @@ -70,6 +71,17 @@ export const Graph = Model.extend({ | |||
|
|
|||
| opt = opt || {}; | |||
|
|
|||
| this.enableCellLayers = opt.enableCellLayers || false; | |||
There was a problem hiding this comment.
does not seem to be used anywhere
kumilingus
reviewed
Jul 11, 2025
| this._unregisterLayer(layerView); | ||
| this.addLayer(layerName, layerView, { insertBefore }); | ||
| if (!layer) { | ||
| throw new Error('dia.Paper: The layer view is not an instance of dia.LayerView.'); |
There was a problem hiding this comment.
the error is not exactly what the check does
kumilingus
reviewed
Jul 21, 2025
| }, | ||
|
|
||
| // @deprecated | ||
| getLastCell: function() { |
There was a problem hiding this comment.
should accept layerName now and not be deprecated
kumilingus
reviewed
Jul 21, 2025
| @@ -117,7 +117,7 @@ export const HighlighterView = mvc.View.extend({ | |||
| vGroup = V('g').addClass('highlight-transform').append(el); | |||
| } | |||
| this.transformGroup = vGroup; | |||
| paper.getLayerView(layerName).insertSortedNode(vGroup.node, options.z); | |||
| paper.getLayer(layerName).insertSortedNode(vGroup.node, options.z); | |||
There was a problem hiding this comment.
paper.geLayer() should stay paper.getLayerView() (same analogy to graph.findCellsInArea() and paper.findCellViewsInArea()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new functionality to the Graph and Paper which allows to use layers for the embedding. The behaviour controlled by
useLayersForEmbeddinggraph option.Motivation and Context
Make possible to use layers for embedding.