feat(dia.ElementView): allow setting initialParentId explicitly for unembedding validation #3024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nembedding validation
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the ElementView's pointer event handling to preserve explicitly set initialParentId values in event data. This change supports validation mechanisms by allowing the initialParentId to be set externally before the unembedding process, rather than being overwritten to null.
- Prevents overwriting of pre-set
initialParentIdvalues in event data - Enables external components like Halo to set dummy values for unembedding validation
kumilingus
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not discard
initialParentIdthat has been explicitly set beforehand in event data.Motivation and Context
Halowill use the existing mechanism to revert (remove) forked/cloned elements ifpaper.options.validateUnembeddingreturnsfalse.