Skip to content

fix: skip bash tests on Windows #19277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025

Conversation

ThomasK33
Copy link
Member

@ThomasK33 ThomasK33 commented Aug 11, 2025

Adds Windows compatibility to toolsdk tests

This PR adds Windows compatibility to the toolsdk tests by:

  1. Adding build constraints to exclude bash_test.go from running on Windows
  2. Skipping the WorkspaceSSHExec test on Windows platforms with a clear message

These changes ensure tests run properly across all supported platforms.

Related to coder/internal#798

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ThomasK33 ThomasK33 force-pushed the thomask33/fix_skip_bash_tests_on_Windows branch from 9d0b4cc to 31b973d Compare August 11, 2025 08:30
@ThomasK33 ThomasK33 marked this pull request as ready for review August 11, 2025 08:31
Change-Id: I8838e8c2d38766ad142e1f5bb224a2f82ac17d6b
Signed-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33 ThomasK33 force-pushed the thomask33/fix_skip_bash_tests_on_Windows branch from 31b973d to 9bbf58f Compare August 11, 2025 08:44
@ThomasK33 ThomasK33 merged commit b7e0266 into main Aug 11, 2025
52 of 53 checks passed
@ThomasK33 ThomasK33 deleted the thomask33/fix_skip_bash_tests_on_Windows branch August 11, 2025 09:43
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants