Skip to content

add patch for sql dqs=0 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

hoxbro
Copy link

@hoxbro hoxbro commented Mar 2, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #34

This PR adds the patch done in grantjenks/python-diskcache#311. I haven't checked for other places in the codespace where this could be needed.

It's my first time using the patch feature, so I could have done something wrong...

@hoxbro hoxbro marked this pull request as ready for review March 2, 2025 10:02
@hoxbro hoxbro requested review from pmlandwehr and xhochy as code owners March 2, 2025 10:02
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@hoxbro hoxbro changed the title add patch for sql dqs=off add patch for sql dqs=0 Mar 3, 2025
@hoxbro
Copy link
Author

hoxbro commented Mar 3, 2025

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13625089018. Examine the logs at this URL for more detail.

@hoxbro hoxbro closed this Mar 3, 2025
@hoxbro hoxbro reopened this Mar 3, 2025
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@whophil
Copy link

whophil commented Mar 3, 2025

To add some context for reviewers:

Changes to either sqlite-feedstock or diskcache upstream are likely to take longer. To me, patching the diskcache feedstock seems like a reasonable option in the interim.

And one bump for @pmlandwehr @xhochy, thanks for maintining this feedstock!

@hoxbro
Copy link
Author

hoxbro commented Mar 10, 2025

Ping @conda-forge/diskcache; it would be nice to have this merged.

@whophil
Copy link

whophil commented Mar 16, 2025

I believe this should no longer be necessary since the merge of conda-forge/sqlite-feedstock#132

@hoxbro hoxbro closed this Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to sqlite-feedstock break diskcache
3 participants