DGS-21595 Allow alternate KMS key IDs on a KEK #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for alternate KMS key IDs when working with KEK (Key Encryption Key) operations. The change allows specifying multiple KMS keys as fallback options for encryption and decryption operations, improving resilience when primary KMS keys are unavailable.
- Introduces a new configuration parameter
encrypt.alternate.kms.key.idsto specify alternate KMS key IDs - Creates a
KmsClientWrapperclass that handles failover logic between multiple KMS keys - Updates encryption/decryption logic to use the wrapper instead of direct KMS client calls
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| schemaregistry/rules/encryption/encrypt-executor.ts | Adds KmsClientWrapper class with failover logic and updates KMS client instantiation |
| schemaregistry/test/serde/avro.spec.ts | Adds test case to verify encryption with alternate KEKs functionality |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please prefix all TypeScript pull-requests with
[Typescript]What
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups