feat(auth): .well-known endpoints delegated to auth server #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Nuri <marc@marcnuri.com>
ardaguclu
reviewed
Aug 7, 2025
| @@ -32,9 +33,6 @@ func AuthorizationMiddleware(requireOAuth bool, serverURL string, oidcProvider * | |||
| } | |||
|
|
|||
| audience := Audience | |||
| if serverURL != "" { | |||
There was a problem hiding this comment.
Removal of this makes sense for demo purposes. But in the future, we need to have server url specific audience, otherwise, any user can generate a token for mcp-server audience and sends here.
There was a problem hiding this comment.
Was thinking of providing the audience via config flag (considering our internal document for the Keycloak integration)
There was a problem hiding this comment.
Getting audience via flag is a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @ardaguclu