chore!: Update finish reason in output of HuggingFaceAPIChatGenerator to match between stream and non-stream modes
#9686
+32
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 16878499788Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
…ish-reason-hf-api-chat-gen
HuggingFaceAPIChatGenerator to match between stream and non-stream modesHuggingFaceAPIChatGenerator to match between stream and non-stream modes
Amnah199
reviewed
Aug 11, 2025
releasenotes/notes/update-finish-reason-hf-api-chat-gen-c700042a079733e8.yaml
Outdated
Show resolved
Hide resolved
…2a079733e8.yaml Co-authored-by: Amna Mubashar <amnahkhan.ak@gmail.com>
Amnah199
reviewed
Aug 11, 2025
…pset-ai/haystack into update-finish-reason-hf-api-chat-gen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
finish_reasonvalues inHuggingFaceAPIChatGeneratorhaystack-core-integrations#2141Proposed Changes:
In this previous PR, we introduced a finish_reason field to StreamingChunk. When used with the HuggingFaceAPIChatGenerator, this new field was included in the meta of the returned ChatMessage. However, the update only applied when streaming was enabled. If streaming was disabled, the old finish_reason was still returned. This PR fixes that by ensuring the updated finish_reason is used even when streaming is off.
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.