Fix inconsistent top_k validation in SentenceTransformersDiversityRanker #9698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change elif to if in run() method to ensure top_k validation always runs regardless of whatever top_k comes from init or runtime - Both scenarios now consistently raise ValueError with descriptive message format: 'top_k must be between 1 and X, but got Y' - Fixes inconsistency where init top_k gave confusing MMR error while runtime top_k gave clear validation error
|
|
|
@SaurabhLingam thanks for this PR. Unfortunately, the tests are failing because this component has a very inconsistent behavior: #9695 (comment) |
|
@SaurabhLingam could you please modify this PR according #9695 (comment)?
Please also add a release note, as explained here. It should contain something like: fixes:
- |
Ensure consistent behavior in `SentenceTransformersDiversityRanker`. Like other rankers, it now returns
all documents instead of raising an error when `top_k` exceeds the number of available documents. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes
SentenceTransformersDiversityRankerwith MMR - inconsistenttop_khandling #9695changed elif to if in run() method to ensure top_k validation always runs regardless of whatever top_k comes from init or runtime
Both scenarios now consistently raise ValueError with descriptive message format: 'top_k must be between 1 and X, but got Y'
Fixes inconsistency where init top_k gave confusing MMR error while runtime top_k gave clear validation error