DEV: Ensure poll with @mentions and user statuses renders without errors #34014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced `isElementInDocument` to ensure components are rendered only in valid DOM elements. Prevents application crashes caused by rendering into detached or removed elements.
Introduced a new poll fixture `/pie_chart_poll_with_mention.json` and an associated test to verify rendering of polls containing `@mention`. Ensures the poll is rendered correctly.
isElementInDocument method to validate target elements
davidtaylorhq
approved these changes
Aug 1, 2025
martin-brennan
pushed a commit
that referenced
this pull request
Aug 5, 2025
…ors (#34014) This commit ensures that polls including @mentions of users with active user statuses are rendered correctly without errors. It introduces a document validation check before rendering components, adds fixtures for polls with mentions, and provides acceptance tests to verify proper rendering of polls containing @mentions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that polls including @mentions of users with active user statuses are rendered correctly without errors. It introduces a document validation check before rendering components, adds fixtures for polls with mentions, and provides acceptance tests to verify proper rendering of polls containing @mentions.